Fix incorrect check in issuer_or_subject_length function #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic error in the
issuer_or_subject_lengthfunction described in issue #30.Problem:
The
elseclause was incorrectly attached to theif common:statement, meaning the TypeError would only be raised if thecommonparameter was falsy, rather than checking if any certificate information was provided.Solution:
Changed the logic to check
if not tot_len:after all parameters have been processed, ensuring the TypeError is raised when no certificate information is provided, regardless of which parameter is missing.Changes:
issuer_or_subject_lengthfunctionFixes #30