fix: Fixes after 2227

[andiwand]

clang tidy fixes after #2227

[codecov]

Codecov Report

Merging #2565 (691eb8e) into main (13f9308) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2565   +/-   ##
=======================================
  Coverage   49.64%   49.64%           
=======================================
  Files         471      471           
  Lines       26632    26632           
  Branches    12237    12237           
=======================================
  Hits        13222    13222           
  Misses       4742     4742           
  Partials     8668     8668           

Files	Coverage Δ
...re/include/Acts/TrackFinding/FasTrackConnector.hpp	0.00% <ø> (ø)
Core/src/TrackFinding/RoiDescriptor.cpp	0.00% <0.00%> (ø)
Core/src/TrackFinding/FasTrackConnector.cpp	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊: Physics performance monitoring for 691eb8e

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Particles inital fatras
• ✅ Particles final fatras
• ✅ Particles inital geant4
• ✅ Particles final geant4

[paulgessinger]

Looks good to me thanks!

[acts-project-service]

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🔴	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data

[timadye]

Hi @andiwand,
Thank you so much for the extensive tidying over the weekend!
Just for my information, was this produced directly from clang-tidy, or did you have to edit the code? I'm just wondering if the clever fixes are the result of human or artificial intelligence. 🤖 😄
Thanks,
Tim.

CC: @Rosie-Hasan

[andiwand]

@timadye I did it manually. I think for some stuff it can do it but I did not try it yet