feat: Initial version of ATLAS-based FTF seeding #2227

Rosie-Hasan · 2023-06-21T10:57:45Z

First few files needed for FTF seeding. Does not create seeds yet, made to check current progress is compatible.

… works

Rosie-Hasan · 2023-10-20T15:28:06Z

@andiwand Great, thank you so much for all your help!

Rosie-Hasan · 2023-10-20T16:13:25Z

It has the "This branch is out-of-date with the base branch" warning should I update the branch or will I cause it to reset ?

andiwand · 2023-10-21T06:47:25Z

It has the "This branch is out-of-date with the base branch" warning should I update the branch or will I cause it to reset ?

that should not be a problem. but CI Bridge seems to be. @paulgessinger do you know why it refuses to run?

paulgessinger · 2023-10-21T07:20:28Z

I need to add @Rosie-Hasan to the relevant GitHub team for that to work.

EDIT: Done now, but you'll have to accept the team invitation before it's effective.

benjaminhuth · 2023-10-21T12:35:36Z

Hmm codecov is failing on this @paulgessinger

paulgessinger · 2023-10-21T13:31:24Z

Well it does it's job 😄
I'll override it for this!.

acts-project-service · 2023-10-21T14:58:03Z

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status	job
🔴	run_workflow_tests_run2_data
🔴	run_unit_tests
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🟢	run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🟢	run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data

AJPfleger · 2023-10-21T18:50:41Z

I believe this merge fails the clang_tidy check and errors in CI Bridge / lcg_104: [alma9, clang16].

Building it locally also gave me a bunch of warnings.

paulgessinger · 2023-10-21T20:19:49Z

I thought I checked and they were green earlier.

I'll fix them tomorrow.

andiwand · 2023-10-21T20:48:18Z

I started fixing this here #2565

clang tidy fixes after #2227

timadye · 2023-10-24T16:39:07Z

Core/include/Acts/Seeding/GNN_TrackingFilter.hpp

+    memset(&m_Cx[0][0], 0, sizeof(m_Cx));
+    memset(&m_Cy[0][0], 0, sizeof(m_Cy));


This is a trial for commenting on already-merged code as a prompt for future improvement.

Please replace memset by std::fill. memset here is undefined behaviour, but works because 0.0f is represented by 4 '\0's. A bit awkwardly, you need to specify the number of elements as sizeof(m_Cx)/sizeof(m_Cx[0][0]).

If m_Cx were a std::array, then it would know its own size and all would be good.

Change naming of new seeding algorithm from FTF (FastTrackFinder) to GBTS (Graph Based Track Seeding) as this is a clearer desription of the algorithm. Name changes disccuessed in issue #2831 . Code implemented in PRs #2227 #2726 and more details given presented at [ACTS-ITK presention ](https://indico.cern.ch/event/1321208/#20-update-on-ftf-implementatio). **Name changes**: SeedFinderFTF -> SeedFinderGBTS GNN_DataStorage -> GBTSDataStorage GNN_Geometry -> GBTSGeometry SeedingFTFAlgorithm -> GBTSSeedingAlgorithm FasTrackConnector-> GBTSConnector TrigBase -> GBTSBase full_chain_itk_FTF.py -> full_chain_itk_GBTS.py

Change naming of new seeding algorithm from FTF (FastTrackFinder) to GBTS (Graph Based Track Seeding) as this is a clearer desription of the algorithm. Name changes disccuessed in issue acts-project#2831 . Code implemented in PRs acts-project#2227 acts-project#2726 and more details given presented at [ACTS-ITK presention ](https://indico.cern.ch/event/1321208/#20-update-on-ftf-implementatio). **Name changes**: SeedFinderFTF -> SeedFinderGBTS GNN_DataStorage -> GBTSDataStorage GNN_Geometry -> GBTSGeometry SeedingFTFAlgorithm -> GBTSSeedingAlgorithm FasTrackConnector-> GBTSConnector TrigBase -> GBTSBase full_chain_itk_FTF.py -> full_chain_itk_GBTS.py

First few files needed for FTF seeding. Does not create seeds yet, made to check current progress is compatible.

clang tidy fixes after acts-project#2227

Change naming of new seeding algorithm from FTF (FastTrackFinder) to GBTS (Graph Based Track Seeding) as this is a clearer desription of the algorithm. Name changes disccuessed in issue acts-project#2831 . Code implemented in PRs acts-project#2227 acts-project#2726 and more details given presented at [ACTS-ITK presention ](https://indico.cern.ch/event/1321208/#20-update-on-ftf-implementatio). **Name changes**: SeedFinderFTF -> SeedFinderGBTS GNN_DataStorage -> GBTSDataStorage GNN_Geometry -> GBTSGeometry SeedingFTFAlgorithm -> GBTSSeedingAlgorithm FasTrackConnector-> GBTSConnector TrigBase -> GBTSBase full_chain_itk_FTF.py -> full_chain_itk_GBTS.py

First few files needed for FTF seeding. Does not create seeds yet, made to check current progress is compatible.

clang tidy fixes after acts-project#2227

Change naming of new seeding algorithm from FTF (FastTrackFinder) to GBTS (Graph Based Track Seeding) as this is a clearer desription of the algorithm. Name changes disccuessed in issue acts-project#2831 . Code implemented in PRs acts-project#2227 acts-project#2726 and more details given presented at [ACTS-ITK presention ](https://indico.cern.ch/event/1321208/#20-update-on-ftf-implementatio). **Name changes**: SeedFinderFTF -> SeedFinderGBTS GNN_DataStorage -> GBTSDataStorage GNN_Geometry -> GBTSGeometry SeedingFTFAlgorithm -> GBTSSeedingAlgorithm FasTrackConnector-> GBTSConnector TrigBase -> GBTSBase full_chain_itk_FTF.py -> full_chain_itk_GBTS.py

Rosie-Hasan added 30 commits February 24, 2023 19:30

adding reco with commented out FTF as it crashes everythin, currently…

4dcbcd5

… works

python part of FTF seeding working, but algorithm replaced with ortho

799d9c5

dummy seeding algorithm now working

75d83c3

python code works, prints out and plots histogram

45b99b8

works and makes a csv

17025c3

table of conversions so far

b7120c9

all working rn

7c7d5b4

addding pdf

5c892f8

end of day all working, csvs updated

c93e3d6

got plots ready for slides

e368114

improved conversion table

cd6e1eb

adding reco with commented out FTF as it crashes everythin, currently…

c564cf3

… works

python part of FTF seeding working, but algorithm replaced with ortho

74902cb

dummy seeding algorithm now working

d45dc94

python code works, prints out and plots histogram

ee72329

works and makes a csv

ff1a408

table of conversions so far

5257787

all working rn

6273d4c

addding pdf

f9dd0eb

end of day all working, csvs updated

01f3e20

got plots ready for slides

1e7cac0

improved conversion table

047cd11

saving before I try and update ACTS

f3f2846

saving before pulling

c883b6f

please work

d26d587

trying to update ACTS

0d8f57d

had some git stuff in the file

d4b619d

removing all <<HEAD

976274a

moving mapping to own file

edb90d9

building and running now since ACTS update, FTF dummy seeding broken

128873c

timadye approved these changes Oct 20, 2023

View reviewed changes

benjaminhuth removed the automerge label Oct 21, 2023

paulgessinger changed the title ~~feat: FTF seeding~~ feat: Initial version of ATLAS-based FTF seeding Oct 21, 2023

paulgessinger merged commit 13f9308 into acts-project:main Oct 21, 2023

acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 21, 2023

andiwand mentioned this pull request Oct 21, 2023

fix: Fixes after 2227 #2565

Merged

kodiakhq bot pushed a commit that referenced this pull request Oct 22, 2023

fix: Fixes after 2227 (#2565)

9b6cf2f

clang tidy fixes after #2227

timadye reviewed Oct 24, 2023

View reviewed changes

paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023

Rosie-Hasan mentioned this pull request Dec 14, 2023

Improvement: Proposed name change of FTF -> GBTS seeding #2831

Closed

Rosie-Hasan mentioned this pull request Dec 21, 2023

refactor: name change of FTF -> GBTS seeding #2853

Merged

njacazio pushed a commit to njacazio/acts that referenced this pull request Jun 13, 2025

feat: Initial version of ATLAS-based FTF seeding (acts-project#2227)

d056e9f

First few files needed for FTF seeding. Does not create seeds yet, made to check current progress is compatible.

njacazio pushed a commit to njacazio/acts that referenced this pull request Jun 13, 2025

fix: Fixes after 2227 (acts-project#2565)

b55f8dd

clang tidy fixes after acts-project#2227

njacazio pushed a commit to njacazio/acts that referenced this pull request Jun 13, 2025

feat: Initial version of ATLAS-based FTF seeding (acts-project#2227)

e47876e

First few files needed for FTF seeding. Does not create seeds yet, made to check current progress is compatible.

njacazio pushed a commit to njacazio/acts that referenced this pull request Jun 13, 2025

fix: Fixes after 2227 (acts-project#2565)

6458c73

clang tidy fixes after acts-project#2227

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Initial version of ATLAS-based FTF seeding #2227

feat: Initial version of ATLAS-based FTF seeding #2227

Uh oh!

Rosie-Hasan commented Jun 21, 2023

Uh oh!

Rosie-Hasan commented Oct 20, 2023

Uh oh!

Rosie-Hasan commented Oct 20, 2023

Uh oh!

andiwand commented Oct 21, 2023

Uh oh!

paulgessinger commented Oct 21, 2023 •

edited

Loading

Uh oh!

benjaminhuth commented Oct 21, 2023

Uh oh!

paulgessinger commented Oct 21, 2023

Uh oh!

acts-project-service commented Oct 21, 2023

Uh oh!

AJPfleger commented Oct 21, 2023 •

edited

Loading

Uh oh!

paulgessinger commented Oct 21, 2023 •

edited

Loading

Uh oh!

andiwand commented Oct 21, 2023

Uh oh!

timadye Oct 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

		memset(&m_Cx[0][0], 0, sizeof(m_Cx));
		memset(&m_Cy[0][0], 0, sizeof(m_Cy));

feat: Initial version of ATLAS-based FTF seeding #2227

feat: Initial version of ATLAS-based FTF seeding #2227

Uh oh!

Conversation

Rosie-Hasan commented Jun 21, 2023

Uh oh!

Rosie-Hasan commented Oct 20, 2023

Uh oh!

Rosie-Hasan commented Oct 20, 2023

Uh oh!

andiwand commented Oct 21, 2023

Uh oh!

paulgessinger commented Oct 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjaminhuth commented Oct 21, 2023

Uh oh!

paulgessinger commented Oct 21, 2023

Uh oh!

acts-project-service commented Oct 21, 2023

🔴 Athena integration test results

🔴 Some tests have failed!

Uh oh!

AJPfleger commented Oct 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulgessinger commented Oct 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andiwand commented Oct 21, 2023

Uh oh!

timadye Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

paulgessinger commented Oct 21, 2023 •

edited

Loading

AJPfleger commented Oct 21, 2023 •

edited

Loading

paulgessinger commented Oct 21, 2023 •

edited

Loading