allow tu prefix collection #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsegura
reviewed
Dec 19, 2022
src/Command/CreateCommand.php
Outdated
| $output->writeln(sprintf('<info>Deleting</info> <comment>%s</comment>', $name)); | ||
| $this->collectionManager->deleteCollection($name); | ||
| $output->writeln(sprintf('<info>Deleting</info> <comment>%s</comment> (<comment>%s</comment> in Typesense)', $name, $typesenseName)); | ||
| $this->collectionManager->deleteCollextion($name); |
Contributor
There was a problem hiding this comment.
Why not use method name without typo?
Member
Author
There was a problem hiding this comment.
You are right, I will fix it 😄
| typesense: | ||
| url: 'http://localhost:8108' | ||
| key: 'ACSEO' | ||
| collection_prefix: 'acseo_prefix_' |
Contributor
There was a problem hiding this comment.
Will this work with parameters / environment placeholders?
Like:
collection_prefix: "%app_name%_"collection_prefix: "%env(APP_NAME)%_"
This was referenced Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this MR thanks to @alexsegura idea and contribution, in order to allow to prefix all collection names in typesense.