Allow "collection_name" parameter. #62
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm running multiple instances of the same webapp against a unique Typesense server, and I'm using namespaces/prefixes for collection names. For example let's say I have a
productscollection, there would be collections prefixed by the app name (app_A_products,app_B_products, etc). Also, on my dev environment, I have a specific collection for tests (i.eapp_products_test).All of this is made dynamic by using env vars.
Of course, I would like to use the "generic" name (i.e
products) inside my code, while having TypesenseBundle classes target the expected collection.I noticed there is a
collection_nameparameter which seems designed for this, but is unused. So I tried to make it work.Not sure what I did is 100% correct as I'm not an expert in Symfony dependency injection.
As a result, with the following configuration:
$collectionManager->createCollection('products')(for example), it actually creates theapp_A_productscollectiontypesense.finder.productswhich actually targets the collectionapp_A_productsRelated to #22