H-01 SpokePool's fill Function Performs Malformed Call

[bmzig]

The fill function of the SpokePool contract is meant to adhere to the IDestinationSettler interface, as dictated by the latest update to the ERC-7683 specifications. The fill function is meant to internally call the fillV3Relay function in order to process the order data, and it does so by making a delegatecall to its own fillV3Relay function, passing abi.encodePacked(originData, fillerData) as the parameter.

However, the fillV3Relay function accepts two parameters, having the repaymentChainId as the second parameter. Since the call is constructed using encodeWithSelector, which is not type-safe, the compiler does not complain about the missing parameter. As an incorrect number of parameters is passed, the call to fillV3Relay will always revert when trying to decode the input parameters, breaking the entire execution flow. Moreover, the input data is encoded with abi.encodePacked the use of which is discouraged, especially when dealing with structs and dynamic types like arrays.

Consider using encodeCall instead of encodeWithSelector to ensure type safety, and providing the parameters required by the fillV3Relay function separately. In addition, consider explicitly making the SpokePool contract inherit from the IDestinationSettler interface as required by the ERC-7683 standard.

This PR performs the suggested change and decodes the input data to fields of fillV3Relay, so that abi.encodeCall can be used.

[nicholaspai]

Much safer, LGTM