fix: N01-N14: Address Noncritical Issues #728
Conversation
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
bmzig
changed the title
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
There was a problem hiding this comment.
LGTM - I was able to reconcile all changes to the notes raised by the audit. I have a couple of residual queries to align on cc @mrice32 @nicholaspai
|
|
||
| // Arbitrum only supports v0.8.19 | ||
| // See https://docs.arbitrum.io/for-devs/concepts/differences-between-arbitrum-ethereum/solidity-support#differences-from-solidity-on-ethereum | ||
| pragma solidity ^0.8.19; |
There was a problem hiding this comment.
Same as above RE potentially updating this pragma in light of subsequent ArbOS updates removing lifting a historical constraint.
This reverts commit 36b4869.
Signed-off-by: bennett <bennett@umaproject.org>
|
Can you comment on which lines are related to which issues? would make it faster to review |
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
Paul made comments on most of them, and I covered the gaps. There should be comments for 1-14 |
There was a problem hiding this comment.
https://github.com/across-protocol/contracts/pull/728/files#r1844570282
https://github.com/across-protocol/contracts/pull/728/files#r1846744574
https://github.com/across-protocol/contracts/pull/728/files#r1846747834
A few outstanding comments then we'll be good, good work!
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
This updates parts of the L3 code which were deemed as non-critical issues.