feat: Added constants & address generation scripts to pre-commit hook #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
fusmanii
commented
Sep 16, 2025
Comment on lines
-35
to
-41
| echo "" | ||
| echo "Generated files:" | ||
| echo " - $PROJECT_ROOT/broadcast/deployed-addresses.md (Markdown format)" | ||
| echo " - $PROJECT_ROOT/broadcast/deployed-addresses.json (JSON format)" | ||
| echo " - $PROJECT_ROOT/script/DeployedAddresses.sol (Foundry smart contract with all addresses)" | ||
| echo "" | ||
| echo "You can now import DeployedAddresses.sol in your other Foundry scripts to use the deployed addresses." No newline at end of file |
There was a problem hiding this comment.
Removed these looks to make it less noisy
fusmanii
commented
Sep 16, 2025
Comment on lines
-303
to
-321
| // Log the sorting priority for visibility | ||
| console.log("\nChain sorting priority:"); | ||
| const mainnetChains = sortedChainIds.filter((id) => Object.values(MAINNET_CHAIN_IDs).includes(id)); | ||
| const testnetChains = sortedChainIds.filter((id) => Object.values(TESTNET_CHAIN_IDs).includes(id)); | ||
| const otherChains = sortedChainIds.filter( | ||
| (id) => !Object.values(MAINNET_CHAIN_IDs).includes(id) && !Object.values(TESTNET_CHAIN_IDs).includes(id) | ||
| ); | ||
|
|
||
| console.log( | ||
| ` Mainnet chains (${mainnetChains.length}): ${mainnetChains.map((id) => `${getChainName(id)}(${id})`).join(", ")}` | ||
| ); | ||
| console.log( | ||
| ` Testnet chains (${testnetChains.length}): ${testnetChains.map((id) => `${getChainName(id)}(${id})`).join(", ")}` | ||
| ); | ||
| console.log( | ||
| ` Other chains (${otherChains.length}): ${otherChains.map((id) => `${getChainName(id)}(${id})`).join(", ")}` | ||
| ); | ||
| console.log(""); | ||
|
|
There was a problem hiding this comment.
same here, all the changes in this file are removing logs
nicholaspai
reviewed
Sep 16, 2025
| }, | ||
| "MulticallHandler": { | ||
| "address": "0x924a9f036260DdD5808007E1AA95f08eD08aA569", | ||
| "address": "0x0F7Ae28dE1C8532170AD4ee566B5801485c13a0E", |
There was a problem hiding this comment.
Is this right? This contract isn't verified
There was a problem hiding this comment.
nice catch, looks like non of the 0x0F7Ae28dE1C8532170AD4ee566B5801485c13a0E are verified, will confirm if its the right address
There was a problem hiding this comment.
The addresses are correct but looks like they were never verified. I verified all of the unverified contracts
nicholaspai
reviewed
Sep 16, 2025
pxrl
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also contains changes from #1058, but I can move to another pr if its easier to review like that