feat(Foundry): zkSync support #1097

fusmanii · 2025-09-04T02:39:51Z

The checkZkSyncChain function in DeploymentUtils will ensure that zksync chains are compiled and deployed with zksolc

socket-security · 2025-09-04T02:41:55Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

nicholaspai

I have a question about how a manual test mistake can still sidestep this new check.

nicholaspai · 2025-09-04T21:17:49Z

script/059DeployLensSpokePool.s.sol

 // 4. Deploy with:
-//        forge script script/059DeployLensSpokePool.s.sol:DeployLensSpokePool --rpc-url \
-//        $NODE_URL_1 --broadcast --verify --verifier blockscout --verifier-url https://verify.lens.xyz/contract_verification
+//        yarn forge-script-zksync script/059DeployLensSpokePool.s.sol:DeployLensSpokePool --rpc-url lens \


So what would happen if you ran this script without the zksync suffix? Would an error throw somewhere?

you dont need the zksync suffix, as long as FOUNDRY_PROFILE=zksync is there, it will compile with zksolc

And if you dont have that env var for lens and zksync then the check will fail

this flag is the same as adding the --zksync flag

pxrl · 2025-09-09T12:54:45Z

script/utils/DeploymentUtils.sol

+    function checkZkSyncChain(uint256 chainId) internal view {
+        bool isZkSyncChain = chainId == getChainId("ZK_SYNC") ||
+            chainId == getChainId("ZK_SYNC_SEPOLIA") ||
+            chainId == getChainId("LENS") ||
+            chainId == getChainId("LENS_TESTNET");
+
+        string memory foundryProfile = vm.envOr("FOUNDRY_PROFILE", string("default"));
+
+        if (isZkSyncChain) {
+            vm.assertEq(
+                foundryProfile,
+                string("zksync"),
+                "Chain is a ZkSync chain but FOUNDRY_PROFILE is not zksync. Use yarn forge-script-zksync to deploy"
+            );
+        }
+    }


@fusmanii We have the family attribute in the networks definitions in constants - wdyt about just evaluating on that?

@pxrl I can make the change in my constants.json pr since I don't have the family attribute exposed yet

All good, though that PR is now closed - is there something to replace it? Just want to make sure we circle back to it.

yup, recreating that pr since it got very messy, will include in that

.gitignore

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

pxrl · 2025-09-17T14:42:07Z

README.md

+export FOUNDRY_PROFILE=zksync
+
+forge script script/016DeployZkSyncSpokePool.s.sol:DeployZkSyncSpokePool --rpc-url zksync --broadcast --verify -vvvv


Using export in the example will make FOUNDRY_PROFILE persist beyond the deployment; it might be better to set it at runtime so it's not persistent:

Suggested change

export FOUNDRY_PROFILE=zksync

forge script script/016DeployZkSyncSpokePool.s.sol:DeployZkSyncSpokePool --rpc-url zksync --broadcast --verify -vvvv

FOUNDRY_PROFILE=zksync forge script script/016DeployZkSyncSpokePool.s.sol:DeployZkSyncSpokePool --rpc-url zksync --broadcast --verify -vvvv

good point, merging this and will add this change to a follow up pr

fusmanii force-pushed the faisal/foundry-zksync branch from 617116f to 730bee5 Compare September 4, 2025 02:40

fusmanii marked this pull request as ready for review September 4, 2025 18:57

fusmanii requested review from bmzig, mrice32, nicholaspai and pxrl as code owners September 4, 2025 18:57

fusmanii requested review from dijanin-brat and grasphoper September 4, 2025 18:57

nicholaspai previously approved these changes Sep 4, 2025

View reviewed changes

fusmanii dismissed nicholaspai’s stale review via 89b513e September 5, 2025 13:46

fusmanii requested a review from nicholaspai September 5, 2025 13:50

nicholaspai previously approved these changes Sep 8, 2025

View reviewed changes

pxrl reviewed Sep 9, 2025

View reviewed changes

.gitignore Show resolved Hide resolved

fusmanii dismissed nicholaspai’s stale review via 341c84b September 9, 2025 14:09

fusmanii force-pushed the faisal/foundry-zksync branch from 341c84b to a2d6999 Compare September 9, 2025 14:09

fusmanii requested a review from pxrl September 9, 2025 14:13

fusmanii force-pushed the faisal/foundry-zksync branch 2 times, most recently from e289de3 to 71d4a3c Compare September 16, 2025 15:40

fusmanii added 8 commits September 16, 2025 15:12

feat(Foundry): zkSync support

3160b04

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Added forge sksync script

831c41e

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Added forge zksync command

211d1e2

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Added foundry zksync profile check in deployment utils

96d46f1

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Removed redundant check

ebedbbd

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Fixed zksync profile

edcc212

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Added zkout to clean script

1598dcd

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Added zksync rpc and readme

812d0f1

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

fusmanii force-pushed the faisal/foundry-zksync branch from 71d4a3c to 812d0f1 Compare September 16, 2025 19:13

pxrl approved these changes Sep 17, 2025

View reviewed changes

pxrl reviewed Sep 17, 2025

View reviewed changes

fusmanii merged commit f722857 into master Sep 17, 2025
10 checks passed

fusmanii deleted the faisal/foundry-zksync branch September 17, 2025 14:52

		export FOUNDRY_PROFILE=zksync

		forge script script/016DeployZkSyncSpokePool.s.sol:DeployZkSyncSpokePool --rpc-url zksync --broadcast --verify -vvvv

feat(Foundry): zkSync support #1097

feat(Foundry): zkSync support #1097

Uh oh!

Conversation

fusmanii commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicholaspai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fusmanii Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fusmanii commented Sep 4, 2025 •

edited

Loading

socket-security bot commented Sep 4, 2025 •

edited

Loading

fusmanii Sep 17, 2025 •

edited

Loading