feat: Update constants.json usage #1096
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fusmanii
force-pushed
the
faisal/generate-constants-json
branch
from
98dcbfa to
e78b1e9
Compare
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
pxrl
reviewed
Sep 4, 2025
bmzig
reviewed
Sep 4, 2025
| } | ||
|
|
||
| // Helper function to extract USDC addresses | ||
| function extractUsdcAddresses(): { [key: string]: string } { |
There was a problem hiding this comment.
Two questions for this entire file:
- Why are we setting the keys as the chain name? I would think it's a lot easier for foundry to know the network's chainId over the name of the network itself?
- Maybe a stupid question, but these functions seem really complex for what they are doing. Why can't we just call
JSON.stringify(USDC)and similar things for all of these other functions? I think adding this much code to just extract values from a map makes the script itself pretty rigid/hard to maintain.
There was a problem hiding this comment.
Good idea, I updated the scripts to fetch by chainid instead 4677066
make every a lot cleaner
fusmanii
force-pushed
the
faisal/generate-constants-json
branch
from
56f1e0f to
ae04d5f
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
fusmanii
force-pushed
the
faisal/generate-constants-json
branch
from
db95804 to
517c64b
Compare
fusmanii
commented
Sep 9, 2025
fusmanii
changed the base branch from
master
to
faisal/generate-constants-json-script
fusmanii
force-pushed
the
faisal/generate-constants-json
branch
3 times, most recently
from
a689cd4 to
61301b7
Compare
Base automatically changed from
faisal/generate-constants-json-script
to
master
September 12, 2025 16:13
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
force-pushed
the
faisal/generate-constants-json
branch
from
61301b7 to
7343ab1
Compare
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
force-pushed
the
faisal/generate-constants-json
branch
from
1558e42 to
1e7ae2b
Compare
fusmanii
changed the title
|
This pr is very messy now, I will close this and recreate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the generated constants.json in foundry scripts
Resolves https://linear.app/uma/issue/ACX-4371/fully-generate-contract-configs-constants-from-constants-exports
See #1102 first which has the script
and then #1105 which generates the
constants.jsonfile