fix[N02] Move all structs to the same place #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <christopher.maree@gmail.com>
chrismaree
requested review from
mrice32 and
nicholaspai
and removed request for
mrice32
chrismaree
added
the
OZ Audit - March
nicholaspai
requested changes
Mar 17, 2022
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
This should also move the PooledToken and CrossChainContract structs to the interface as per the issue description
Member
|
You also may as well add the |
Member
Author
good point! fixed. |
This was referenced Apr 6, 2022
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The PoolRebalanceLeaf struct is defined in HubPoolInterface.sol, while the RootBundle,
PooledToken, and CrossChainContract structs are all defined in the implementation, HubPool.sol.
Consider defining all structs for HubPool within the same contract.
Resolution:
pull the structs to all be in the interface.