chrismaree/mainnet deployment #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
approved these changes
May 3, 2022
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
lgtm! everything looks good, no issues
nicholaspai
reviewed
May 4, 2022
package.json
Outdated
| { | ||
| "name": "@across-protocol/contracts-v2", | ||
| "version": "0.0.44", | ||
| "version": "0.0.47", |
Member
There was a problem hiding this comment.
+1 this matches the version I just pushed
chrismaree
commented
May 5, 2022
| @@ -0,0 +1,41 @@ | |||
| # Across Mainnet Deployment Addresses | |||
Member
Author
There was a problem hiding this comment.
Reviewers! see this file
chrismaree
commented
May 5, 2022
| @@ -0,0 +1,73 @@ | |||
| // import { getDeployedAddress } from "../src/DeploymentUtils"; | |||
|
|
|||
| import { task, types } from "hardhat/config"; | |||
Member
Author
There was a problem hiding this comment.
Reviewers! see this file
nicholaspai
reviewed
May 5, 2022
|
|
||
| console.log("\n7. Adding calldata to set the pool rebalance route for the respective destination tokens:"); | ||
| i = 0; // reset counter for logging. | ||
| enabledChainIds.forEach((toId, toIndex) => { |
Member
There was a problem hiding this comment.
tiny nit: why not just use toIndex instead of i in {++i}?
nicholaspai
reviewed
May 5, 2022
tsconfig.json
Outdated
| "target": "es2021", | ||
| "module": "commonjs", | ||
| "strict": true, | ||
| "strict": false, |
Member
There was a problem hiding this comment.
ideally we don't commit this change to strict
Member
Author
There was a problem hiding this comment.
sure. will fix with more strict typing and revert this change.
This was referenced May 6, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.