Skip to content

Conversation

@tejasync
Copy link
Contributor

@tejasync tejasync commented May 25, 2023

Support PHP8 upgrade

@tejasync tejasync changed the title [WIP] : MAUT-8990 : Upgrade to PHP8 MAUT-8990 : Upgrade to PHP8 Jun 22, 2023
@tejasync tejasync requested review from dadarya0 and rohitp19 June 22, 2023 06:46
rohitp19
rohitp19 previously approved these changes Jun 22, 2023
Copy link
Contributor

@rohitp19 rohitp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as team already reviewed it.

dadarya0
dadarya0 previously approved these changes Jun 22, 2023
@tejasync tejasync dismissed stale reviews from rohitp19 and dadarya0 via 26a9063 December 28, 2023 10:45
Co-authored-by: Saurabh Gupta <48244990+dadarya0@users.noreply.github.com>
Copy link
Contributor

@dadarya0 dadarya0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found 1 minor change.

@tejasync tejasync requested a review from dadarya0 December 28, 2023 11:16
Copy link
Contributor

@rohitp19 rohitp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tejasync tejasync requested review from dadarya0 and rohitp19 January 3, 2024 09:49
@himanshuprajapati-1 himanshuprajapati-1 merged commit c871af0 into staging Jan 9, 2024
@himanshuprajapati-1 himanshuprajapati-1 deleted the MAUT-8990 branch January 9, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants