Merge pull request #319 from acquia/MAUT-8990

MAUT-8990 : Upgrade to PHP8

Author: himanshuprajapati-1

EventListener/SegmentFiltersMergeSubscriber.php

@@ -48,7 +48,7 @@ public function mergeCustomObjectFilters(LeadListMergeFiltersEvent $event): void
                 }
             }
 
-            if ('custom_object' !== $filter['object']) {
+            if ('custom_object' !== ($filter['object'] ?? '')) {
                 $finalMergedFilters[] = $filter;
                 continue;
             }

EventListener/TokenSubscriber.php

@@ -312,7 +312,7 @@ private function getCustomFieldValues(CustomObject $customObject, Token $token,
             try {
                 $fieldValue    = $customItem->findCustomFieldValueForFieldAlias($token->getCustomFieldAlias());
                 // If the CO item doesn't have a value, get the default value
-                if ('' == $fieldValue->getValue()) {
+                if (empty($fieldValue->getValue())) {
                     $fieldValue->setValue($fieldValue->getCustomField()->getDefaultValue());
                 }
                 $fieldValues[] = $fieldValue->getCustomField()->getTypeObject()->valueToString($fieldValue);

Form/Type/CustomFieldType.php

@@ -260,7 +260,7 @@ private function buildModalFormFields(FormBuilderInterface $builder, array $opti
             ]
         );
 
-        $builder->setAction($options['action']);
+        $builder->setAction($options['action'] ?? '');
     }
 
     /**