Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AddShareDataFrame request #242

Merged
merged 20 commits into from
Jun 30, 2023
Merged

Add AddShareDataFrame request #242

merged 20 commits into from
Jun 30, 2023

Conversation

mdonaka
Copy link
Contributor

@mdonaka mdonaka commented Jun 27, 2023 •
edited
Loading

depends on #241

Summary

Add AddShareDataFrame request

Purpose

libclient-py specification changes

Contents

  • Add the following request
service LibcToManage {
    rpc AddShareDataFrame(AddShareDataFrameRequest) returns (AddShareDataFrameResponse) {}
}
message AddShareDataFrameRequest {
    string base_data_id = 1;
    string add_data_id = 2;
    string token = 3;
}
message AddShareDataFrameResponse {
    string data_id = 1;
}

Testing Methods Performed

  • Use this request before sending a join request
  • medium test
  • CI

@mdonaka mdonaka force-pushed the feature/nakata/add_addrequest branch 2 times, most recently from f6221ba to 67fe3ae Compare June 28, 2023 06:05
@mdonaka mdonaka marked this pull request as ready for review June 28, 2023 06:54
@mdonaka mdonaka changed the base branch from main to feature/nakata/share_data_frame June 28, 2023 07:25
@KotaTakahashi9320 KotaTakahashi9320 mentioned this pull request Jun 28, 2023
Merged
@mdonaka mdonaka force-pushed the feature/nakata/share_data_frame branch from 31607e9 to 3646d8e Compare June 29, 2023 06:33
@mdonaka mdonaka force-pushed the feature/nakata/add_addrequest branch from 67fe3ae to 6475808 Compare June 29, 2023 06:34
KotaTakahashi9320
KotaTakahashi9320 approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdonaka
Thanks!
LGTM

@mdonaka mdonaka force-pushed the feature/nakata/share_data_frame branch from 0e98638 to 9823c14 Compare June 30, 2023 03:39
Base automatically changed from feature/nakata/share_data_frame to main June 30, 2023 04:19
@mdonaka mdonaka force-pushed the feature/nakata/add_addrequest branch from 6475808 to 39907ea Compare June 30, 2023 04:20
@mdonaka mdonaka merged commit 2eda104 into main Jun 30, 2023
@mdonaka mdonaka deleted the feature/nakata/add_addrequest branch June 30, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KotaTakahashi9320 KotaTakahashi9320 KotaTakahashi9320 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdonaka @KotaTakahashi9320