Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShareDataFrame class #241

Merged
merged 18 commits into from
Jun 30, 2023
Merged

Add ShareDataFrame class #241

merged 18 commits into from
Jun 30, 2023

Conversation

mdonaka
Copy link
Contributor

@mdonaka mdonaka commented Jun 27, 2023

depends on #239

Summary

Add ShareDataFrame class

Purpose

libclient-py specification changes

Contents

  • Add ShareDataFrame class
  • Add new qmpc class

Testing Methods Performed

  • medium test
  • CI

@mdonaka mdonaka force-pushed the feature/nakata/share_data_frame branch 2 times, most recently from 4550c65 to 31607e9 Compare June 28, 2023 06:04
@mdonaka mdonaka marked this pull request as ready for review June 28, 2023 06:53
Copy link
Contributor Author

@mdonaka mdonaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: update test_get_computation_result

Copy link
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdonaka
Thank you!
It's a small detail, but please confirm.

packages/client/libclient-py/quickmpc/qmpc.py Show resolved Hide resolved
@mdonaka mdonaka force-pushed the feature/nakata/share_data_frame branch from 31607e9 to 3646d8e Compare June 29, 2023 06:33
@mdonaka
Copy link
Contributor Author

mdonaka commented Jun 29, 2023

@KotaTakahashi9320
I fixed. Could you check?

Copy link
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdonaka
Thanks!
I made one comment.

Copy link
Collaborator

@KotaTakahashi9320 KotaTakahashi9320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdonaka mdonaka force-pushed the feature/nakata/share_data_frame branch from 0e98638 to 9823c14 Compare June 30, 2023 03:39
@mdonaka mdonaka merged commit c1068b7 into main Jun 30, 2023
@mdonaka mdonaka deleted the feature/nakata/share_data_frame branch June 30, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants