Skip to content

[Publications] Error and swal fix #7326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2021
Merged

[Publications] Error and swal fix #7326

merged 1 commit into from
Feb 15, 2021

Conversation

@laemtl
Copy link
Contributor

@laemtl laemtl commented Feb 5, 2021 •
edited
Loading

Small changes following the comment made in #7315

Replace #7091

@laemtl laemtl mentioned this pull request Feb 5, 2021
Closed
@driusan
Copy link
Collaborator

driusan commented Feb 8, 2021

@maltheism Maybe you can review?

maltheism
maltheism requested changes Feb 8, 2021
View reviewed changes
Copy link
Member

@maltheism maltheism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laemtl, I'm not seeing the swal when there's an error in the publication module. Example if I'm trying to make a publication with the exact details as an existing one. I think the showPublicationError() function is to blame in the ajax/FileUpload.php

@laemtl
Copy link
Contributor Author

laemtl commented Feb 12, 2021 •
edited
Loading

@maltheism I just tried and got an error message:

Screenshot from 2021-02-11 19-40-42

@laemtl laemtl force-pushed the 2020-02-05-publications-error-fix branch from dfb4dca to 1811175 Compare February 12, 2021 00:43
@laemtl laemtl requested a review from maltheism February 12, 2021 00:46
@maltheism maltheism added the Passed manual tests PR has been successfully tested by at least one peer label Feb 15, 2021
maltheism
maltheism approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@maltheism maltheism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laemtl, it works now for me. I'm unsure why it wasn't before. Maybe I didn't delete my cache, sorry!

@driusan driusan merged commit 98a481b into aces:main Feb 15, 2021
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@laemtl @AlexandraLivadas
[Publications] Error and swal fix (aces#7326)
918afef 
Small changes following the comment made in aces#7315

- Fix missing error message
- Fix missing swal callback change (aces#6195 regression) previously in aces#7091

Replace aces#7091
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltheism maltheism maltheism approved these changes

Assignees

No one assigned

Labels

Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@laemtl @driusan @maltheism @ridz1208