[Issue Tracker] jQuery cleanup #7315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
force-pushed
the
2021-02-02-Issue-Trackker-jQuery-cleanup
branch
from
9c183ca to
386a12b
Compare
Collaborator
|
@maltheism Can you review? Looks good to me but I just skimmed it to be sure it's just doing what it says.. |
maltheism
approved these changes
Feb 4, 2021
Member
maltheism
left a comment
maltheism
left a comment
There was a problem hiding this comment.
Hi @laemtl @driusan, the PR is creating the issue without jquery successfully so I'm approving. I did notice that the redirect is broken after the issue is created. That seems to be on the main branch as well. Lastly, the error message from the server is not being shown and once again that's on main as well.
maltheism
added
the
Passed manual tests
Contributor
Author
|
@maltheism Thanks for your comment. I believe the same problems were fixed for Publication, after the swal migration. I can have a look. |
This was referenced Feb 4, 2021
driusan
pushed a commit
that referenced
this pull request
Feb 15, 2021
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Convert jQuery to fetch API in Issue Tracker.
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.