Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion generator/enum_string.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const (
{{- if $value.Comment}}
// {{$value.Comment}}
{{- end}}
{{$value.PrefixedName}} {{$enumName}} = "{{$value.ValueStr}}"
{{$value.PrefixedName}} {{$enumName}} = {{quote $value.ValueStr}}
{{- end}}
)
{{if .names -}}
Expand Down
24 changes: 13 additions & 11 deletions generator/generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ func NewGenerator() *Generator {
funcs["unmapify"] = Unmapify
funcs["namify"] = Namify
funcs["offset"] = Offset
funcs["quote"] = strconv.Quote

g.t.Funcs(funcs)

Expand Down Expand Up @@ -447,8 +448,8 @@ func (g *Generator) parseEnum(ts *ast.TypeSpec) (*Enum, error) {
data = parsed
valueStr = rawName
}
if isQuoted(dataVal) {
valueStr = trimQuotes(dataVal)
if q := identifyQuoted(dataVal); q != "" {
valueStr = trimQuotes(q, dataVal)
}
} else if unsigned {
newData, err := strconv.ParseUint(dataVal, 0, 64)
Expand Down Expand Up @@ -495,18 +496,19 @@ func (g *Generator) parseEnum(ts *ast.TypeSpec) (*Enum, error) {
return enum, nil
}

func isQuoted(s string) bool {
func identifyQuoted(s string) string {
s = strings.TrimSpace(s)
return (strings.HasPrefix(s, `"`) && strings.HasSuffix(s, `"`)) || (strings.HasPrefix(s, `'`) && strings.HasSuffix(s, `'`))
if strings.HasPrefix(s, `"`) && strings.HasSuffix(s, `"`) {
return `"`
}
if strings.HasPrefix(s, `'`) && strings.HasSuffix(s, `'`) {
return `'`
}
return ""
}

func trimQuotes(s string) string {
s = strings.TrimSpace(s)
for _, quote := range []string{`"`, `'`} {
s = strings.TrimPrefix(s, quote)
s = strings.TrimSuffix(s, quote)
}
return s
func trimQuotes(q, s string) string {
return strings.TrimPrefix(strings.TrimSuffix(strings.TrimSpace(s), q), q)
}

func increment(d interface{}) interface{} {
Expand Down
51 changes: 51 additions & 0 deletions generator/generator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -389,3 +389,54 @@ func TestQuotedStrings(t *testing.T) {
fmt.Println(string(output))
}
}

func TestStringWithSingleDoubleQuoteValue(t *testing.T) {
input := `package test
// ENUM(DoubleQuote='"')
type Char string
`
g := NewGenerator()
f, err := parser.ParseFile(g.fileSet, "TestRequiredErrors", input, parser.ParseComments)
assert.Nil(t, err, "Error parsing no struct input")

output, err := g.Generate(f)
assert.Nil(t, err, "Error generating formatted code")
assert.Contains(t, string(output), "CharDoubleQuote Char = \"\\\"\"")
if false { // Debugging statement
fmt.Println(string(output))
}
}

func TestStringWithSingleSingleQuoteValue(t *testing.T) {
input := `package test
// ENUM(SingleQuote="'")
type Char string
`
g := NewGenerator()
f, err := parser.ParseFile(g.fileSet, "TestRequiredErrors", input, parser.ParseComments)
assert.Nil(t, err, "Error parsing no struct input")

output, err := g.Generate(f)
assert.Nil(t, err, "Error generating formatted code")
assert.Contains(t, string(output), "CharSingleQuote Char = \"'\"")
if false { // Debugging statement
fmt.Println(string(output))
}
}

func TestStringWithSingleBacktickValue(t *testing.T) {
input := `package test
// ENUM(SingleQuote="` + "`" + `")
type Char string
`
g := NewGenerator()
f, err := parser.ParseFile(g.fileSet, "TestRequiredErrors", input, parser.ParseComments)
assert.Nil(t, err, "Error parsing no struct input")

output, err := g.Generate(f)
assert.Nil(t, err, "Error generating formatted code")
assert.Contains(t, string(output), "CharSingleQuote Char = \"`\"")
if false { // Debugging statement
fmt.Println(string(output))
}
}
Loading