fix: fixed generation of string enums with one char being a backtick, single quote or double quote #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abice
approved these changes
Mar 10, 2025
Owner
abice
left a comment
abice
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing some constants for working with a PDF.
A PDF has the operators
'and", when I tried to create constants for these operators it would generated an invalid file.The constant value would be correct, like
OPMoveToNextLineSetSpacingShowText OP = "\"", which is valid, but in the_OPValuemap it would create a key with the value"\\\"", which is invalid.I updated the code to fix that. It passes all the previous tests and now it generates the proper value and the proper key.