Skip to content

Add check on cache length when purging entries #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add check on cache length when purging entries #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion digest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,13 @@ func (da *DigestAuth) Purge(count int) {
}
cache := digestCache(entries)
sort.Sort(cache)
for _, client := range cache[:count] {

limit := count
if len(cache) < count {
limit = len(cache) - 1
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the issue correctly, when Purge is called with count >= len(cache), this triggers a panic because of the range. I think an easier fix would be to just empty the entire cache in this case, right after grabbing a lock, because this is what I think this code effectively does. Or am I missing something?

Also, can you please add a test for this edge case?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abbot sorry for the delayed response - you are correct! I think the current count parameter is to only clear the cache up to a certain point - is this something that can be removed in favor of clearing the entire cache?


for _, client := range cache[:limit] {
delete(da.clients, client.nonce)
}
}
Expand Down