Add check on cache length when purging entries #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbot
requested changes
Jun 19, 2020
| limit := count | ||
| if len(cache) < count { | ||
| limit = len(cache) - 1 | ||
| } |
There was a problem hiding this comment.
If I understand the issue correctly, when Purge is called with count >= len(cache), this triggers a panic because of the range. I think an easier fix would be to just empty the entire cache in this case, right after grabbing a lock, because this is what I think this code effectively does. Or am I missing something?
Also, can you please add a test for this edge case?
There was a problem hiding this comment.
@abbot sorry for the delayed response - you are correct! I think the current count parameter is to only clear the cache up to a certain point - is this something that can be removed in favor of clearing the entire cache?
|
Moved to #70. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the authenticator's cache is purged, there was a consistent
slice bounds out of range [:200] with capacity 181panic occurring. Checking that thecountvariable here does not exceed the actual length of the cache should avoid this panic when the cache is purged.