-
-
Notifications
You must be signed in to change notification settings - Fork 324
Added new animated text - Flicker Animation #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new animated text - Flicker Animation #237
Conversation
|
Kindly help me with these Errors. I am absolutely unaware of how to solve them here on Github. |
|
@CoderInTheWoods, please fix the tests. |
|
@awhitford @SirusCodes here the quick gif image for this animation in action - |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 95.11% 95.31% +0.19%
==========================================
Files 9 10 +1
Lines 430 448 +18
==========================================
+ Hits 409 427 +18
Misses 21 21
Continue to review full report at Codecov.
|
|
This Deploy to Preview Channel is beyond my comprehension. Kindly acknowledge and help with the same. Rest all tests here have been passed I guess? |
|
Don't worry about the deployment preview test. It was meant to fail 😅 |
|
Okay, So now I should wait right? For the reviewers to approve and merge? This is my first experience with contributing to open source. Also, regarding the glow effect, should I add another such animation to the package which allows the text to have glow effect with different colors or something, ? |
|
Hey! I am waiting for a PR review and merge. Let me know if I am needed to make any changes to this one. |
|
@CoderInTheWoods, I am just waiting for @awhitford's review. |
|
@aagarwal1012 ig we don't need Kit class |
Sorry, I completely missed this thing, @CoderInTheWoods please see #211 #216 we don't need to add AnimatedTextKit classes anymore, please update your PR. |
|
Thanks I was saying this since when🤦♂️ |
But how do i pass the smoke test without the kit class? |
|
And i think i have already annotated the kit class as depricated |
|
I am not clear as to what changes do i need to make to the code. Kindly help. |
|
Hey, Kindly let me know what to do, I feel a bit lost. Where exactly do I need to make the changes? I have already used to AnimatedText class and not the Kit class in main.dart. |
example/lib/main.dart
Outdated
| label: 'Flicker', | ||
| color: Colors.pink[300], | ||
| child: AnimatedTextKit( | ||
| // using FlickerAnimateText class instead of "FlickerAnimatedTextKit" class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this comment.
aagarwal1012
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CoderInTheWoods, don't worry about the AnimatedTextKit class, we can deal with that later on once we decided to completely remove the deprecated code. For now, your changes look good to me but can you please add the flicker animated text example in the Readme as well?
|
Sure. I'll make the changes and update the PR |
…E previous commit.
|
Made the changes, kindly review them. |
aagarwal1012
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some minor changes required but I will fix them.
|
@all-contributors add @CoderInTheWoods for code, example, and documentation. |
|
I've put up a pull request to add @CoderInTheWoods! 🎉 |
|
Thanks a lot! Glad to Contribute 😁 |


Hello @aagarwal1012
I have developed a flicker glow text animation for Animated Text Kit. Kindly check this PR.