Skip to content

Conversation

@CoderInTheWoods
Copy link
Contributor

Hello @aagarwal1012

I have developed a flicker glow text animation for Animated Text Kit. Kindly check this PR.

@CoderInTheWoods
Copy link
Contributor Author

Kindly help me with these Errors. I am absolutely unaware of how to solve them here on Github.

@aagarwal1012
Copy link
Owner

@CoderInTheWoods, please fix the tests.

@aagarwal1012
Copy link
Owner

@awhitford @SirusCodes here the quick gif image for this animation in action -

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #237 (f12878f) into master (1d31bec) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   95.11%   95.31%   +0.19%     
==========================================
  Files           9       10       +1     
  Lines         430      448      +18     
==========================================
+ Hits          409      427      +18     
  Misses         21       21              
Impacted Files Coverage Δ
lib/src/flicker.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d31bec...f12878f. Read the comment docs.

@CoderInTheWoods
Copy link
Contributor Author

This Deploy to Preview Channel is beyond my comprehension. Kindly acknowledge and help with the same. Rest all tests here have been passed I guess?

@aagarwal1012
Copy link
Owner

Don't worry about the deployment preview test. It was meant to fail 😅

@CoderInTheWoods
Copy link
Contributor Author

Okay, So now I should wait right?

For the reviewers to approve and merge?

This is my first experience with contributing to open source. Also, regarding the glow effect, should I add another such animation to the package which allows the text to have glow effect with different colors or something, ?

@CoderInTheWoods
Copy link
Contributor Author

Hey! I am waiting for a PR review and merge. Let me know if I am needed to make any changes to this one.

@aagarwal1012
Copy link
Owner

@CoderInTheWoods, I am just waiting for @awhitford's review.

@SirusCodes
Copy link
Collaborator

@aagarwal1012 ig we don't need Kit class

@aagarwal1012
Copy link
Owner

@aagarwal1012 ig we don't need Kit class

Sorry, I completely missed this thing, @CoderInTheWoods please see #211 #216 we don't need to add AnimatedTextKit classes anymore, please update your PR.

@SirusCodes
Copy link
Collaborator

Thanks I was saying this since when🤦‍♂️

@CoderInTheWoods
Copy link
Contributor Author

@aagarwal1012 ig we don't need Kit class

Sorry, I completely missed this thing, @CoderInTheWoods please see #211 #216 we don't need to add AnimatedTextKit classes anymore, please update your PR.

But how do i pass the smoke test without the kit class?

@CoderInTheWoods
Copy link
Contributor Author

And i think i have already annotated the kit class as depricated

@CoderInTheWoods
Copy link
Contributor Author

I am not clear as to what changes do i need to make to the code. Kindly help.

@CoderInTheWoods CoderInTheWoods deleted the issue234_effect12_kalgisheth branch April 13, 2021 19:08
@CoderInTheWoods CoderInTheWoods restored the issue234_effect12_kalgisheth branch April 13, 2021 19:08
@CoderInTheWoods
Copy link
Contributor Author

Hey, Kindly let me know what to do, I feel a bit lost. Where exactly do I need to make the changes? I have already used to AnimatedText class and not the Kit class in main.dart.

@CoderInTheWoods
Copy link
Contributor Author

image

If i am not wrong, u are referring to these changes right? I have already been using this format. Kindly let me know otherwise.

label: 'Flicker',
color: Colors.pink[300],
child: AnimatedTextKit(
// using FlickerAnimateText class instead of "FlickerAnimatedTextKit" class
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this comment.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CoderInTheWoods, don't worry about the AnimatedTextKit class, we can deal with that later on once we decided to completely remove the deprecated code. For now, your changes look good to me but can you please add the flicker animated text example in the Readme as well?

@aagarwal1012 aagarwal1012 added enhancement New feature or request GSSOC21 GirlScript Summer of Code 2021 level3 New features, major bug fixing (45 GSSOC Points) new animated text Request of a new animated text labels Apr 14, 2021
@CoderInTheWoods
Copy link
Contributor Author

Sure. I'll make the changes and update the PR

@CoderInTheWoods
Copy link
Contributor Author

Made the changes, kindly review them.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some minor changes required but I will fix them.

@aagarwal1012 aagarwal1012 changed the base branch from master to v4.2.0 April 14, 2021 16:50
@aagarwal1012 aagarwal1012 merged commit 23d42ae into aagarwal1012:v4.2.0 Apr 14, 2021
@aagarwal1012
Copy link
Owner

@all-contributors add @CoderInTheWoods for code, example, and documentation.

@allcontributors
Copy link
Contributor

@aagarwal1012

I've put up a pull request to add @CoderInTheWoods! 🎉

@CoderInTheWoods
Copy link
Contributor Author

Thanks a lot! Glad to Contribute 😁

@CoderInTheWoods CoderInTheWoods deleted the issue234_effect12_kalgisheth branch April 18, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request GSSOC21 GirlScript Summer of Code 2021 level3 New features, major bug fixing (45 GSSOC Points) new animated text Request of a new animated text

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants