Skip to content

Conversation

@awhitford
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #216 (a30c65a) into master (1748cac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files           9        9           
  Lines         428      428           
=======================================
  Hits          407      407           
  Misses         21       21           
Impacted Files Coverage Δ
lib/src/colorize.dart 95.00% <ø> (ø)
lib/src/fade.dart 100.00% <ø> (ø)
lib/src/rotate.dart 100.00% <ø> (ø)
lib/src/scale.dart 100.00% <ø> (ø)
lib/src/typer.dart 100.00% <ø> (ø)
lib/src/typewriter.dart 100.00% <ø> (ø)
lib/src/wavy.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1748cac...a30c65a. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me. Great work! 💯

@aagarwal1012 aagarwal1012 added the deprecation Features will be deprecated. label Mar 21, 2021
@SirusCodes
Copy link
Collaborator

@awhitford ig example/ios/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata is a file which should be in .gitignore

And can we add MIGRATION.md file as well and all the deprecation warning should have this link?

@awhitford
Copy link
Collaborator Author

example/ios/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata is a file which should be in .gitignore

@SirusCodes As you know, the project uses the GitIgnore Template for Flutter. I don't see this as part of the exclusion.

And can we add MIGRATION.md file as well and all the deprecation warning should have this link?

Please note that I did document some migration advice in the README.
Can you show me an example of a project that has their deprecation warnings link to the MIGRATION page?
(I'm concerned that I don't like the idea of hard-coding URLs in a Deprecation message, especially when projects can get forked.)

@awhitford awhitford merged commit 8691b17 into aagarwal1012:master Mar 21, 2021
@awhitford awhitford deleted the DeprecateKits branch March 21, 2021 18:52
@awhitford
Copy link
Collaborator Author

I felt an urgency to merge it since I don't want new animations to feel the need to add Kit classes. Issues like #215 can further improve usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Features will be deprecated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate legacy Kit classes

3 participants