Skip to content

Sve uzp1 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from
Closed

Sve uzp1 #6

wants to merge 21 commits into from

Conversation

a74nh
Copy link
Owner

@a74nh a74nh commented Oct 5, 2023

Add the SVE variants of UZP1.

This will not build as the corresponding SVE functions do not exist yet.

akoeplinger and others added 21 commits October 4, 2023 14:29
….cs (dotnet#92954)

When building the runtime tests we get a lot of warnings like this:

> CSC : warning CS2002: Source file '/__w/1/s/artifacts/tests/coreclr/obj/AnyOS.x64.Checked/Managed/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro/Vector256_1_ro/gen/op_LeftShift.Byte.cs' specified multiple times [/__w/1/s/src/tests/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro.csproj] [/__w/1/s/src/tests/build.proj]


It turns out that we were generating the same file name for multiple test cases (specifically when using VectorImmBinaryOperatorTest.template), added some validation to the test generator so we throw an error in this case.

A few test cases also needed fixing so they compiled due to a missing closing parenthesis.
* Fuse extract and insert into arm64 ins.

* Extending to vector4.

* Ins index is now a function. Removed newline.

* Refactoring.

* SIMD extract ops have no side offects (to facilitate their elimination). Fixed bug.

* Fixed arm32 build.
The string is actually "Error", not "Failure"
…net#92904)

* Move iOS Mono and NativeAOT runs to their own build+run file for cleanliness. Also fix the format of the weekly iOS HybridGlobalization build runs so all artifacts are built.
Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-alpha.1.23502.7 -> To Version 9.0.100-alpha.1.23503.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Vectorize TensorPrimitives.Exp

* Update src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/TensorPrimitives.netstandard.cs
…92791)

* IndentedTextWriter doesn't use indentation on the first line

* fix build 1
dotnet#92966)

regular objects, as with CMake 3.20, we no longer need to go through
the full interfaces path.
* Add CoreclrVerbose=true when --verbose is passed as option to build.sh

Sponsored by: Tekvox Inc.
Cc: Jim Reinhart <jimr@tekvox.com>
Cc: James Autry <jautry@tekvox.com>
Cc: Matthew Maron <matthewm@tekvox.com>
Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>

* Remove leftover comment about -skipcrossarchnative

During commit 7d562f9 comment about
-skipcrossarchnative has been forgotten, so let's remove it since that
flag is not available anymore.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

* Correct shift value

---------

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Co-authored-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
* Add APIs for LoadVector*x2

* Add implementation for LoadVector*x2

* Add APIs for LoadVector*x3

* Add implementation for LoadVector*x3

* Add APIs for LoadVector*x4

* Add implementation for LoadVector*x4

* Add test cases for LoadVectorx2, LoadVectorx3, LoadVectorx4

* minor rename

* REVERT: Add Debug.Assert(false) to make sure test runs

* Retain gtOtherReg rather than making it an array

* Revert "REVERT: Add Debug.Assert(false) to make sure test runs"

This reverts commit 92fb279.

* fix the test template

* fix the LoadVectorx4 template

* address review comment

* fix one more error in LoadVectorx4Test.template

* feedback by Bruce

* Rename the test case name

* Disable test for mono
* fix AOT-llvm flags for linux_x64 perf job

* unify x64 and arm64 AOT build flags for Perf jobs

* Setup x64 MonoAOT runs to be tagged as LLVM.

* run mono-aot-cross command on Helix before job


---------

Co-authored-by: Parker Bibus <parkerbibus@microsoft.com>
This whole things is not applicable to NativeAOT, don't even build it.
dd52 was building test.dll and dev10_897464 was building Test.dll which caused assembly resolving conflicts:

> warning MSB3243: No way to resolve conflict between "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" and "test, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null". Choosing "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" arbitrarily.

Fixed by making the test assembly names unique for each test.
Leftover change from hackathon. Existing code is widening to Int128 and then counting zeros. It still worked because we only use it for bit shifting and bit shifts do wrap around if they're > 64. But this was bringing Int128 into `Runtime.Base` in my hackathon project.
TEST_IMG: ubuntu/dotnet-build
TEST_CMD: echo # This patch is not expect to build

Jira: ENTLLT-6871
Change-Id: I0b6034296d36a044a847b65f1f4cf508ad3494f7
@a74nh a74nh closed this Oct 5, 2023
@a74nh a74nh deleted the sve_uzp1 branch October 5, 2023 13:07
@a74nh a74nh restored the sve_uzp1 branch October 5, 2023 13:08
@a74nh a74nh deleted the sve_uzp1 branch October 5, 2023 13:10
@a74nh a74nh restored the sve_uzp1 branch October 5, 2023 13:11
@a74nh a74nh deleted the sve_uzp1 branch October 5, 2023 13:11
a74nh pushed a commit that referenced this pull request Sep 9, 2024
* bug #1: don't allow for values out of the SerializationRecordType enum range

* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type

* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)

* bug #4: document the fact that IOException can be thrown

* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails

* bug #6: 0 and 17 are illegal values for PrimitiveType enum

* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.