Skip to content

Fix duplicate file name generated by GenerateHWIntrinsicTests_General.cs #92954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Oct 3, 2023

When building the runtime tests we get a lot of warnings like this:

CSC : warning CS2002: Source file '/__w/1/s/artifacts/tests/coreclr/obj/AnyOS.x64.Checked/Managed/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro/Vector256_1_ro/gen/op_LeftShift.Byte.cs' specified multiple times [/__w/1/s/src/tests/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro.csproj] [/__w/1/s/src/tests/build.proj]

It turns out that we were generating the same file name for multiple test cases (specifically when using VectorImmBinaryOperatorTest.template), added some validation to the test generator so we throw an error in this case.

A few test cases also needed fixing so they compiled due to a missing closing parenthesis.

When building the runtime tests we get a lot of warnings like this:

```
CSC : warning CS2002: Source file '/__w/1/s/artifacts/tests/coreclr/obj/AnyOS.x64.Checked/Managed/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro/Vector256_1_ro/gen/op_LeftShift.Byte.cs' specified multiple times [/__w/1/s/src/tests/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro.csproj] [/__w/1/s/src/tests/build.proj]
```

It turns out that we were generating the same file name for multiple test cases (specifically when using VectorImmBinaryOperatorTest.template), added some validation to the test generator so we throw an error in this case.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 3, 2023
@ghost ghost assigned akoeplinger Oct 3, 2023
@akoeplinger akoeplinger added area-System.Runtime.Intrinsics and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details

When building the runtime tests we get a lot of warnings like this:

CSC : warning CS2002: Source file '/__w/1/s/artifacts/tests/coreclr/obj/AnyOS.x64.Checked/Managed/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro/Vector256_1_ro/gen/op_LeftShift.Byte.cs' specified multiple times [/__w/1/s/src/tests/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_ro.csproj] [/__w/1/s/src/tests/build.proj]

It turns out that we were generating the same file name for multiple test cases (specifically when using VectorImmBinaryOperatorTest.template), added some validation to the test generator so we throw an error in this case.

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-System.Runtime.Intrinsics

Milestone: -

@akoeplinger akoeplinger merged commit 55945c6 into dotnet:main Oct 4, 2023
@akoeplinger akoeplinger deleted the fix-generatehwintrinsicstests branch October 4, 2023 12:29
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants