Skip to content

fix: Add additional methods in TaskUpdater #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjuma merged 1 commit into from
Oct 20, 2025
Merged

fix: Add additional methods in TaskUpdater #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions server-common/src/main/java/io/a2a/server/tasks/TaskUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ private void updateStatus(TaskState taskState) {
updateStatus(taskState, null, taskState.isFinal());
}

private void updateStatus(TaskState taskState, Message message) {
public void updateStatus(TaskState taskState, Message message) {
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Making this method public is a good step towards a more flexible API. However, it creates a slight inconsistency because other methods like requiresInput and requiresAuth allow overriding the isFinal flag, a capability this new generic method lacks. This could be confusing for users of this class.

To improve API consistency, consider also making the three-argument updateStatus method (currently at line 39) public. This would provide a fully flexible generic entry point for all status updates.

A more consistent API design could look like this:

// Convenience overload, as it is now
public void updateStatus(TaskState taskState, Message message) {
    updateStatus(taskState, message, taskState.isFinal());
}

// Generic method with full flexibility, made public
public void updateStatus(TaskState state, Message message, boolean isFinal) {
    // ... current implementation
}

This would make the TaskUpdater API more predictable and robust.

Copy link
Collaborator Author

@fjuma fjuma Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

updateStatus(taskState, message, taskState.isFinal());
}

private void updateStatus(TaskState state, Message message, boolean isFinal) {
public void updateStatus(TaskState state, Message message, boolean isFinal) {
synchronized (stateLock) {
// Check if we're already in a terminal state
if (terminalStateReached.get()) {
Expand All @@ -62,6 +62,10 @@ public String getContextId() {
return this.contextId;
}

public String getTaskId() {
return this.taskId;
}

public void addArtifact(List<Part<?>> parts) {
addArtifact(parts, null, null, null);
}
Expand Down