fix: Add additional methods in TaskUpdater#378
Conversation
Summary of ChangesHello @fjuma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces minor but impactful enhancements to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces two small but useful updates to the TaskUpdater class. It adds a getTaskId() method for better data access and makes the updateStatus(TaskState, Message) method public for more flexible status updates. The addition of getTaskId() is a straightforward improvement. For the updateStatus method change, I've added a comment with a suggestion to further improve the API's consistency and prevent potential confusion for developers using this class.
| } | ||
|
|
||
| private void updateStatus(TaskState taskState, Message message) { | ||
| public void updateStatus(TaskState taskState, Message message) { |
There was a problem hiding this comment.
Making this method public is a good step towards a more flexible API. However, it creates a slight inconsistency because other methods like requiresInput and requiresAuth allow overriding the isFinal flag, a capability this new generic method lacks. This could be confusing for users of this class.
To improve API consistency, consider also making the three-argument updateStatus method (currently at line 39) public. This would provide a fully flexible generic entry point for all status updates.
A more consistent API design could look like this:
// Convenience overload, as it is now
public void updateStatus(TaskState taskState, Message message) {
updateStatus(taskState, message, taskState.isFinal());
}
// Generic method with full flexibility, made public
public void updateStatus(TaskState state, Message message, boolean isFinal) {
// ... current implementation
}This would make the TaskUpdater API more predictable and robust.
Small updates to TaskUpdater that I found useful while working on a2aproject#338
Small updates to TaskUpdater that I found useful while working on #338