Skip to content

fix: Add additional methods in TaskUpdater#378

Merged
fjuma merged 1 commit intoa2aproject:mainfrom
fjuma:task_updater
Oct 20, 2025
Merged

fix: Add additional methods in TaskUpdater#378
fjuma merged 1 commit intoa2aproject:mainfrom
fjuma:task_updater

Conversation

@fjuma
Copy link
Collaborator

@fjuma fjuma commented Oct 20, 2025

Small updates to TaskUpdater that I found useful while working on #338

@fjuma fjuma requested a review from kabir October 20, 2025 19:11
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fjuma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces minor but impactful enhancements to the TaskUpdater utility. It expands the accessibility of a key status update method and adds a new accessor for the task identifier, addressing needs identified during work on another issue. These changes aim to improve the flexibility and usability of TaskUpdater for managing task states and retrieving essential task information.

Highlights

  • Method Visibility: The updateStatus method in TaskUpdater that accepts a TaskState and a Message has been changed from private to public, allowing external classes to directly update a task's status with an associated message.
  • New Accessor Method: A new public method, getTaskId(), has been added to the TaskUpdater class, providing direct access to the taskId associated with the updater instance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two small but useful updates to the TaskUpdater class. It adds a getTaskId() method for better data access and makes the updateStatus(TaskState, Message) method public for more flexible status updates. The addition of getTaskId() is a straightforward improvement. For the updateStatus method change, I've added a comment with a suggestion to further improve the API's consistency and prevent potential confusion for developers using this class.

}

private void updateStatus(TaskState taskState, Message message) {
public void updateStatus(TaskState taskState, Message message) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Making this method public is a good step towards a more flexible API. However, it creates a slight inconsistency because other methods like requiresInput and requiresAuth allow overriding the isFinal flag, a capability this new generic method lacks. This could be confusing for users of this class.

To improve API consistency, consider also making the three-argument updateStatus method (currently at line 39) public. This would provide a fully flexible generic entry point for all status updates.

A more consistent API design could look like this:

// Convenience overload, as it is now
public void updateStatus(TaskState taskState, Message message) {
    updateStatus(taskState, message, taskState.isFinal());
}

// Generic method with full flexibility, made public
public void updateStatus(TaskState state, Message message, boolean isFinal) {
    // ... current implementation
}

This would make the TaskUpdater API more predictable and robust.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@fjuma fjuma merged commit e81b35a into a2aproject:main Oct 20, 2025
8 checks passed
kabir pushed a commit to kabir/a2a-java that referenced this pull request Dec 23, 2025
Small updates to TaskUpdater that I found useful while working on a2aproject#338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants