Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove obsolete clippy allows in non_finalized_state #8140

Merged

Conversation

bishopcheckmate
Copy link
Contributor

Motivation

I was reading the codebase and found these two #[allow()]s obsolete

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

Just remove the obsolete allows

Testing

cargo +nightly clippy -p zebra-state

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@bishopcheckmate bishopcheckmate requested a review from a team as a code owner January 8, 2024 21:29
@bishopcheckmate bishopcheckmate requested review from arya2 and removed request for a team January 8, 2024 21:29
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jan 8, 2024
@teor2345 teor2345 self-assigned this Jan 8, 2024
@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ A-diagnostics Area: Diagnosing issues or monitoring performance A-state Area: State / database changes and removed extra-reviews This PR needs at least 2 reviews to merge labels Jan 8, 2024
Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this cleanup!

Please let us know if you'd like more suggestions for what to work on.

@teor2345 teor2345 removed the request for review from arya2 January 8, 2024 22:45
mergify bot added a commit that referenced this pull request Jan 9, 2024
@mergify mergify bot merged commit 07693a1 into ZcashFoundation:main Jan 9, 2024
100 checks passed
@bishopcheckmate
Copy link
Contributor Author

@teor2345 I'd appreciate some issue to get started. Do you have anything in mind?

@teor2345
Copy link
Collaborator

@teor2345 I'd appreciate some issue to get started. Do you have anything in mind?

You could try something from this list of tickets:
https://github.com/ZcashFoundation/zebra/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22good+first+issue%22

Or you could ask the developers in the #zebra channel in the Zcash R&D discord:
https://discord.com/channels/809218587167293450/809251029673312267

Here's a link that will let you join the Discord for the next week:
https://discord.gg/GvhwHwXR

@oxarbitrage oxarbitrage mentioned this pull request Jan 17, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance A-state Area: State / database changes C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants