Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.5.1 #8165

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Release v1.5.1 #8165

merged 6 commits into from
Jan 19, 2024

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Jan 17, 2024


name: 'Release Checklist Template'
about: 'Checklist to create and publish a Zebra release'
title: 'Release Zebra (version)'
labels: 'A-release, C-trivial, P-Critical 🚑'
assignees: ''


Prepare for the Release

  • Make sure there has been at least one successful full sync test since the last state change, or start a manual full sync.
  • Make sure the PRs with the new checkpoint hashes and missed dependencies are already merged.
    (See the release ticket checklist for details)

Summarise Release Changes

These steps can be done a few days before the release, in the same PR:

Change Log

Important: Any merge into main deletes any edits to the draft changelog.
Once you are ready to tag a release, copy the draft changelog into CHANGELOG.md.

We use the Release Drafter workflow to automatically create a draft changelog. We follow the Keep a Changelog format.

To create the final change log:

  • Copy the latest draft changelog into CHANGELOG.md (there can be multiple draft releases)
  • Delete any trivial changes
    • Put the list of deleted changelog entries in a PR comment to make reviewing easier
  • Combine duplicate changes
  • Edit change descriptions so they will make sense to Zebra users
  • Check the category for each change
    • Prefer the "Fix" category if you're not sure

README

README updates can be skipped for urgent releases.

Update the README to:

  • Remove any "Known Issues" that have been fixed since the last release.
  • Update the "Build and Run Instructions" with any new dependencies.
    Check for changes in the Dockerfile since the last tag: git diff <previous-release-tag> docker/Dockerfile.
  • If Zebra has started using newer Rust language features or standard library APIs, update the known working Rust version in the README, book, and Cargo.tomls

You can use a command like:

fastmod --fixed-strings '1.58' '1.65'

Create the Release PR

  • Push the updated changelog and README into a new branch
    for example: bump-v1.0.0 - this needs to be different to the tag name
  • Create a release PR by adding &template=release-checklist.md to the comparing url (Example).
  • Freeze the batched queue using Mergify.
  • Mark all the release PRs as Critical priority, so they go in the urgent Mergify queue.
  • Mark all non-release PRs with do-not-merge, because Mergify checks approved PRs against every commit, even when a queue is frozen.

Update Versions and End of Support

Update Zebra Version

Choose a Release Level

Zebra follows semantic versioning. Semantic versions look like: MAJOR.MINOR.PATCH[-TAG.PRE-RELEASE]

Choose a release level for zebrad. Release levels are based on user-visible changes from the changelog:

  • Mainnet Network Upgrades are major releases
  • significant new features or behaviour changes; changes to RPCs, command-line, or configs; and deprecations or removals are minor releases
  • otherwise, it is a patch release

Zebra's Rust API doesn't have any support or stability guarantees, so we keep all the zebra-* and tower-* crates on a beta pre-release version.

Update Crate Versions

If you're publishing crates for the first time, log in to crates.io,
and make sure you're a member of owners group.

Check that the release will work:

  • Update crate versions, commit the changes to the release branch, and do a release dry-run:
cargo release version --verbose --execute --allow-branch '*' --workspace --exclude zebrad --exclude zebra-scan beta
# Due to a bug in cargo-release, we need to pass an exact version here
cargo release version --verbose --execute --allow-branch '*' --package zebra-scan 0.1.0-alpha.1
cargo release version --verbose --execute --allow-branch '*' --package zebrad patch # [ major | minor | patch ]
cargo release replace --verbose --execute --allow-branch '*' --package zebrad
cargo release commit --verbose --execute --allow-branch '*'

Crate publishing is automatically checked in CI using "dry run" mode.

Update End of Support

The end of support height is calculated from the current blockchain height:

  • Find where the Zcash blockchain tip is now by using a Zcash explorer or other tool.
  • Replace ESTIMATED_RELEASE_HEIGHT in end_of_support.rs with the height you estimate the release will be tagged.
Optional: calculate the release tagging height
  • Add 1152 blocks for each day until the release
  • For example, if the release is in 3 days, add 1152 * 3 to the current Mainnet block height

Update the Release PR

  • Push the version increments and the release constants to the release branch.

Publish the Zebra Release

Create the GitHub Pre-Release

  • Wait for all the release PRs to be merged
  • Create a new release using the draft release as a base, by clicking the Edit icon in the draft release
  • Set the tag name to the version tag,
    for example: v1.0.0
  • Set the release to target the main branch
  • Set the release title to Zebra followed by the version tag,
    for example: Zebra 1.0.0
  • Replace the prepopulated draft changelog in the release description with the final changelog you created;
    starting just after the title ## [Zebra ... of the current version being released,
    and ending just before the title of the previous release.
  • Mark the release as 'pre-release', until it has been built and tested
  • Publish the pre-release to GitHub using "Publish Release"
  • Delete all the draft releases from the list of releases

Test the Pre-Release

Publish Release

Publish Crates

The publishing didn't worked for v1.5.1. We made a fix and published v1.5.2, the following steps were done with that tag:

  • Publish the crates to crates.io: cargo release publish --verbose --workspace --execute
  • Check that Zebra can be installed from crates.io:
    cargo install --locked --force --version 1.minor.patch zebrad && ~/.cargo/bin/zebrad
    and put the output in a comment on the PR.

Publish Docker Images

Release Failures

If building or running fails after tagging:

Tag a new release, following these instructions...
  1. Fix the bug that caused the failure
  2. Start a new patch release
  3. Skip the Release Preparation, and start at the Release Changes step
  4. Update CHANGELOG.md with details about the fix
  5. Follow the release checklist for the new Zebra version

@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jan 17, 2024
@oxarbitrage
Copy link
Contributor Author

oxarbitrage commented Jan 17, 2024

Removed from changelog:

  • Update copyright year to 2024 (#8134)
  • build(deps): bump jsonrpc from 0.16.0 to 0.17.0 (#8139)
  • build(deps): bump the devops group with 2 updates (#8147)
  • build(deps): bump the devops group with 2 updates (#8126)
  • build(deps): bump the devops group with 2 updates (#8100)
  • build(deps): bump the devops group with 3 updates (#8120)
  • build(deps): bump the prod group with 3 updates (#8158)
  • build(deps): bump the prod group with 4 updates (#8117)
  • build(deps): bump the prod group with 5 updates (#8138)
  • build(deps): bump the prod group with 6 updates (#8125)
  • build(deps): bump zerocopy from 0.7.30 to 0.7.31 (#8111)
  • cleanup: Fix unused code lints (#8148)
  • fix(ci): revert script changes causing workflow failures (#8133)
  • fix(elasticsearch): Make bulk size the same for testnet and mainnet (#8127)
  • fix(test): Ignore segmentation fault errors when shutting down Docker in tests (#8107)
  • fix(workflows): mass rename worflows to fix readme badges (#8116)
  • ref(workflow): move most scripts to their own executables (#8005)
  • refactor: remove obsolete clippy allows in non_finalized_state (#8140)
  • test(scan): Add raw database format snapshots to the scanner (#8075)
  • test(scan): Add typed database format snapshots to the scanner (#8083)
  • test: Add progress markers to the snapshot tests (#8106)
  • tests(sinsemilla): Minor changes to sinsemilla tests (#8128)

Security

  • build(deps): bump zerocopy from 0.7.30 to 0.7.31 (#8111)

(Edited to reflect the changes during the review process.)

@mpguerra mpguerra linked an issue Jan 18, 2024 that may be closed by this pull request
17 tasks
@oxarbitrage oxarbitrage added A-release Area: Zebra releases and release management P-Critical 🚑 labels Jan 18, 2024
@oxarbitrage oxarbitrage marked this pull request as ready for review January 18, 2024 19:06
@oxarbitrage oxarbitrage requested review from a team as code owners January 18, 2024 19:06
@oxarbitrage oxarbitrage requested review from arya2 and upbqdn and removed request for a team January 18, 2024 19:06
@oxarbitrage
Copy link
Contributor Author

upbqdn
upbqdn previously approved these changes Jan 19, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@upbqdn
Copy link
Member

upbqdn commented Jan 19, 2024

I noticed we mention in the release notes that this release adds the reader of the scanning results, but the PR is excluded from the changelog.

Co-authored-by: Marek <mail@marek.onl>
upbqdn
upbqdn previously approved these changes Jan 19, 2024
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a bunch of suggestions.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Marek <mail@marek.onl>
@mergify mergify bot merged commit 5824f85 into main Jan 19, 2024
182 checks passed
@mergify mergify bot deleted the release-v.1.5.1 branch January 19, 2024 21:14
@upbqdn
Copy link
Member

upbqdn commented Jan 19, 2024

I edited the lists of PRs not included in the changelog in the comment above to reflect the changes we made in the review.

@oxarbitrage
Copy link
Contributor Author

There is a problem with the publication of the zebra-chain crate and i am not sure how to proceed.

Only the zebra-test crate was upgraded by now because the command cargo release publish --verbose --workspace --execute fails publishing zebra-chain:

  Publishing zebra-chain
    Updating crates.io index
   Packaging zebra-chain v1.0.0-beta.33 (/home/oxarbitrage/zebra/release-1.5.1/main_with_release/zebra/zebra-chain)
   Verifying zebra-chain v1.0.0-beta.33 (/home/oxarbitrage/zebra/release-1.5.1/main_with_release/zebra/zebra-chain)
    Updating crates.io index
error: failed to verify package tarball

Caused by:
  failed to select a version for `equihash`.
      ... required by package `zebra-chain v1.0.0-beta.33 (/home/oxarbitrage/zebra/release-1.5.1/main_with_release/zebra/target/package/zebra-chain-1.0.0-beta.33)`
  versions that meet the requirements `^0.2.0` are: 0.2.0

  the package `zebra-chain` depends on `equihash`, with features: `solver` but `equihash` does not have these features.


  failed to select a version for `equihash` which could resolve this conflict

This seems to be a problem introduced with the internal miner.

I can try to publish the rest of the crates but i think we will have to make a hotfix(1.5.2) anyway.

@oxarbitrage
Copy link
Contributor Author

An easier way could be to use the --no-verify flag described in https://crates.io/crates/cargo-release.

If that works we can publish as it is and fix for the next release.

arya2 pushed a commit that referenced this pull request Jan 22, 2024
* add 1.5.1 changelog

* extend eos

* chore: Release

* add suggestions from review

Co-authored-by: Marek <mail@marek.onl>

* Apply suggestions from code review

Co-authored-by: Marek <mail@marek.onl>

---------

Co-authored-by: Marek <mail@marek.onl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release Area: Zebra releases and release management C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish next Zebra release: 1.5.1
2 participants