Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(sinsemilla): Minor changes to sinsemilla tests #8128

Merged
merged 2 commits into from
Jan 1, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

I was checking sinsemilla zebra implementation and i found 2 minor things i will like to change so i am pushing this PR, they are trivial things:

  • Group the tests together so a user interested in the sincemila implementation can run cargo test sinsemilla.
  • Replace an old link.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

  • Add a sinsemilla_ prefix to sinsemilla tests. 09fe7f7
  • Replace old link with a working one. 0e7a46f

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage added P-Low ❄️ C-testing Category: These are tests A-cryptography Area: Cryptography related labels Dec 29, 2023
@oxarbitrage oxarbitrage requested a review from a team as a code owner December 29, 2023 21:18
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 29, 2023
Copy link
Collaborator

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mergify bot added a commit that referenced this pull request Jan 1, 2024
@mergify mergify bot merged commit 5abbefd into main Jan 1, 2024
102 checks passed
@mergify mergify bot deleted the sinsemilla-trivial-changes branch January 1, 2024 23:21
@oxarbitrage oxarbitrage mentioned this pull request Jan 17, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cryptography Area: Cryptography related C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants