Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): Add shielded-scan.md to the index #8095

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(doc): Add shielded-scan.md to the index #8095

merged 1 commit into from
Dec 12, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

The new shielded scan docs are not being published to the Zebra book. But other doc updates are being made.

Maybe adding them to the index will help.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Testing

We can test this by merging it, then checking the book.

Review

This is an urgent fix because we just made a blog post about it.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added C-bug Category: This is a bug A-docs Area: Documentation P-High 🔥 C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 12, 2023
@teor2345 teor2345 self-assigned this Dec 12, 2023
@teor2345 teor2345 requested a review from a team as a code owner December 12, 2023 21:43
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team December 12, 2023 21:43
@teor2345 teor2345 mentioned this pull request Dec 12, 2023
Closed
oxarbitrage
oxarbitrage approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

mergify bot added a commit that referenced this pull request Dec 12, 2023
@mergify
Merge of #8095
0e12876
@mergify mergify bot mentioned this pull request Dec 12, 2023
Closed
@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Dec 12, 2023
@mergify
Merge of #8095
350985e
@mergify mergify bot mentioned this pull request Dec 12, 2023
Closed
@mergify mergify bot merged commit ac72c2b into main Dec 12, 2023
91 checks passed
@mergify mergify bot deleted the scan-doc-idx branch December 12, 2023 23:51
@mpguerra mpguerra linked an issue Dec 13, 2023 that may be closed by this pull request
Document how to run and query the results of the blockchain scanning MVP #8046
Closed
@oxarbitrage oxarbitrage mentioned this pull request Jan 17, 2024
Merged
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-docs Area: Documentation C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to run and query the results of the blockchain scanning MVP
2 participants
@teor2345 @oxarbitrage