ref(workflow): move most scripts to their own executables

[gustavovalverde]

Motivation

Some CI files are hard/understand as they have bash scripts included, some of this scripts are also hard to maintain or lint considering they're inside a .yml and not in an actual .sh

Some of these scripts might also be useful as a separate file to run independently for specific use cases, like searching for disks in GCP (but that's not part of the scope of this PR)/

Fixes #6168

Depends-On: #8083

PR Author Checklist

Check before marking the PR as ready for review:

• Will the PR name make sense to users?
• Does the PR have a priority label?
• Have you added or updated tests?
• Is the documentation up to date?

For significant changes:

• Is there a summary in the CHANGELOG?
• Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Complex Code or Requirements

Some scripts required refactoring for consistency and better use outside the workflow YAML

Solution

• Move most scripts to the ./github/workflows/scripts directory
• Lint the scripts to comply with bash linting
• Refactor the scripts so it's easier to make further updates.

Review

We need to confirm the right disk are being pulled, comparing with recent PRs

Reviewer Checklist

Check before approving the PR:

• Does the PR scope match the ticket?
• Are there enough tests to make sure it works? Do the tests cover the PR motivation?
• Are all the PR blockers dealt with?
  PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

Make this scripts usable as a standalone script

[oxarbitrage]

G-cloud issues, i am updating the branch to run everything again and check if that was temporal or already resolved.

[oxarbitrage]

G-cloud issues, i am updating the branch to run everything again and check if that was temporal or already resolved.

Unfortunately this seems to be a bug in the refactor. https://github.com/ZcashFoundation/zebra/actions/runs/7023238162/job/19109744164?pr=8005

[gustavovalverde]

Unfortunately this seems to be a bug in the refactor.

Some fixes were applied. This should be good now

[oxarbitrage]

ERROR: (gcloud.compute.ssh) Could not fetch resource:
 - The resource 'projects/zfnd-dev-zebra/zones/us-east1-c/instances/lwd-send-transactions-8005-merge-bf708ec' was not found

https://github.com/ZcashFoundation/zebra/actions/runs/7094975945/job/19311396467

Updating branch to re run the CI.

[oxarbitrage]

I think this PR simplifies the CI by a lot so i will like to see it merged. However, it seems there is a problem in the changes.

The CI is stuck here:
https://github.com/ZcashFoundation/zebra/actions/runs/7101877538/job/19331501819?pr=8005

What i am most afraid of if that it seems to not be picking the right disks. @gustavovalverde can you take a look and clarify ?

[teor2345]

I think this PR simplifies the CI by a lot so i will like to see it merged. However, it seems there is a problem in the changes.

The CI is stuck here: ZcashFoundation/zebra/actions/runs/7101877538/job/19331501819?pr=8005

What i am most afraid of if that it seems to not be picking the right disks. @gustavovalverde can you take a look and clarify ?

This seems to be the same bug with the runners, I can do the same temporary fix if Gustavo isn't around.

[teor2345]

This seems to be maybe finding the incorrect GCP resource?

[gustavovalverde]

This seems to be maybe finding the incorrect GCP resource?

That's correct. But it's actually because a wrong assignment was being made, and previously the disk was not matching correctly, so @oxarbitrage was right being afraid with CI failing.

There's just a missing fix which I'll end up doing tomorrow.

[gustavovalverde]

@oxarbitrage this is finally good!

The PR is failing as codespell is failing to build, but that's unrelated: https://github.com/ZcashFoundation/zebra/actions/runs/7143157187/job/19454023893?pr=8005

[teor2345]

I've scheduled this after the scanner tests merge, because they are blocking other work.