-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zebra-network): add user agent argument #6601
Conversation
I just want to say that I love deleting stuff from the release checklist 🎉 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6601 +/- ##
==========================================
+ Coverage 77.82% 77.92% +0.09%
==========================================
Files 308 309 +1
Lines 40331 40653 +322
==========================================
+ Hits 31386 31677 +291
- Misses 8945 8976 +31 |
Just letting you know that PR #6606 changes the format of the If you'd like, you can add:
to the PR #6606 description, which will make my PR wait for this one to merge. Then if anything breaks I can fix it. (Just so you know, I'm not planning on reviewing this PR, because Marek is assigned to it.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I left two optional suggestions and one question.
Co-authored-by: Marek <mail@marek.onl>
Thanks! I added your doc suggestions and i tried to reply the question. |
Motivation
We want to give
zebra-network
the possibility of changing the user agent it will use and we also want Zebra to automatically build the user agent by using git data.Close #2375
Solution
zebrad
, build and pass valid user agent to network.zebra-rpc
as it is needed in thegetinfo
rpc method. We haveapp_version
data already here, was needed for the samegetinfo
function, so we have everything to build user agent there too.Review
I think anyone can review, this reduce the number of steps from the release checklist.
Reviewer Checklist
Follow Up Work