Allow different `zebra-network` apps to use different user agents

## Motivation

1. We want `zebrad` to have a different user agent from the ECC's DNS seeder, and other apps that use `zebra-network`

2. We'd like to simplify Zebra's release process, by automatically using a `zebrad` version in the zebra-network user agent.

### Specifications

https://github.com/bitcoin/bips/blob/master/bip-0014.mediawiki

## Solution

- [ ] Add a `user_agent` argument to `zebra_network::init`, and pass it to the handshaker
- [ ] In `zebrad::commands::start`, pass `application::app_version()` to `zebra_network::init`
  - Use the BIP-14 format: "/Zebra:1.0.0-alpha.11/"
- [ ] Add the supplied user agent to the front of the `zebra-network` user agent string, using the BIP-14 syntax

https://github.com/ZcashFoundation/zebra/blob/c40cbee42f0897932b03ba9fbb53bf6219e4c5f8/zebra-network/src/isolated.rs#L43-L59

## Related Work

Make sure custom user agents conform to BIP-14 #794

	pub fn connect_isolated(
	conn: TcpStream,
	user_agent: String,
	) -> impl Future<
	Output = Result<
	BoxService<Request, Response, Box<dyn std::error::Error + Send + Sync + 'static>>,
	Box<dyn std::error::Error + Send + Sync + 'static>,
	>,
	> {
	let handshake = peer::Handshake::builder()
	.with_config(Config::default())
	.with_inbound_service(tower::service_fn(\|_req\| async move {
	Ok::<Response, Box<dyn std::error::Error + Send + Sync + 'static>>(Response::Nil)
	}))
	.with_user_agent(user_agent)
	.finish()
	.expect("provided mandatory builder parameters");

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow different `zebra-network` apps to use different user agents #2375

teor2345
openedon Jun 23, 2021

Motivation

Specifications

Solution

Related Work

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Allow different zebra-network apps to use different user agents #2375

Description

teor2345openedon Jun 23, 2021