Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to 'damage' life bar when 'Again' is selected #35

Merged
merged 2 commits into from
Jun 11, 2019

Conversation

albino
Copy link
Contributor

@albino albino commented Jun 5, 2019

This is a continuation of #34; github decided to close the pull request when I rewrote the commits to fix the issues, so I'm creating a new one, sorry.

All issues highlighted in the previous PR have been resolved.

@Yutsuten Yutsuten added the enhancement Improve an existing feature label Jun 8, 2019
@Yutsuten Yutsuten self-requested a review June 8, 2019 13:44
Copy link
Owner

@Yutsuten Yutsuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

I'll update my local code to use your changes, and test it for a few days. If everything is working as expected, I'll merge it within a week.

Copy link
Owner

@Yutsuten Yutsuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its working nice so far, lets merge it.
Thank you very much for the Pull Request, you did a nice job.

@Yutsuten Yutsuten merged commit f9e18c2 into Yutsuten:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants