Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to 'damage' life bar when 'Again' is selected #34

Closed
wants to merge 2 commits into from

Conversation

albino
Copy link
Contributor

@albino albino commented May 26, 2019

Hi,

Firstly, thanks for making this addon. It's exactly what I was looking for!

I wanted to be able to remove some life when I get an answer incorrect, however, so I decided to try and implement this. Everything functions the same by default but an option can be selected to 'damage' the user's life bar when they choose 'Again'.

What do you think? Might you be interested in merging this?

@Yutsuten Yutsuten self-requested a review May 26, 2019 01:49
@Yutsuten
Copy link
Owner

Thank you for the Pull Request!

I'll take a look into the changes later, but seems to be an interesting feature!

Copy link
Owner

@Yutsuten Yutsuten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes looks very good overall. Just a few points I would improve.

src/lifedrain/lifedrain.py Show resolved Hide resolved
src/lifedrain/lifedrain.py Show resolved Hide resolved
src/lifedrain/lifedrain.py Show resolved Hide resolved
src/lifedrain/lifedrain.py Show resolved Hide resolved
@Yutsuten Yutsuten added the enhancement Improve an existing feature label May 26, 2019
@albino
Copy link
Contributor Author

albino commented May 26, 2019

Thanks for getting back to me so quickly... I'll fix the last two issues when I have access to a PC.

R.e. the negative values for damage, I thought this might be a useful feature to have. Up to you if you want to keep it, I don't mind :-)

@Yutsuten
Copy link
Owner

Lets keep the negative values, as you stated there may be people who would find a use to it.

@albino albino closed this Jun 5, 2019
@albino albino deleted the damage branch June 5, 2019 15:23
@albino albino restored the damage branch June 5, 2019 15:23
@albino
Copy link
Contributor Author

albino commented Jun 5, 2019

continued in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants