Skip to content

Commit

Permalink
Add document for flatten optimization in PeeledEncoding (facebookincu…
Browse files Browse the repository at this point in the history
…bator#10701)

Summary:
Pull Request resolved: facebookincubator#10701

Follow up on facebookincubator#10521 (comment).

Reviewed By: pedroerp

Differential Revision: D61053625
  • Loading branch information
Yuhta authored and facebook-github-bot committed Aug 10, 2024
1 parent 1629101 commit 5f3b62d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions velox/expression/PeeledEncoding.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ class LocalSelectivityVector;
/// translate top level rows into inner rows and wrap a vector (typically
/// generated as a result of applying an expression on the peeled vectors).
///
/// When the base vector size is larger than 8 times of the selected rows, we do
/// not save the dictionary wrapping. Instead, we store a flattened version of
/// the selected rows and return them when needed. The wrapping in this case is
/// kept as FLAT, and the inner/outer rows translation will be identical.
///
/// Typical usage pattern for peeling includes:
/// (See Expr::applyFunctionWithPeeling() for example usage)
/// 1. peeling a set of input vectors
Expand Down

0 comments on commit 5f3b62d

Please sign in to comment.