Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document for flatten optimization in PeeledEncoding #10701

Closed
wants to merge 1 commit into from

Conversation

Yuhta
Copy link
Contributor

@Yuhta Yuhta commented Aug 9, 2024

Summary: Follow up on #10521 (comment).

Differential Revision: D61053625

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2024
Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 5f3b62d
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66b6be977f5a320008a20bea

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61053625

velox/expression/PeeledEncoding.h Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61053625

Yuhta added a commit to Yuhta/velox that referenced this pull request Aug 10, 2024
…bator#10701)

Summary:
Pull Request resolved: facebookincubator#10701

Follow up on facebookincubator#10521 (comment).

Reviewed By: pedroerp

Differential Revision: D61053625
…bator#10701)

Summary:
Pull Request resolved: facebookincubator#10701

Follow up on facebookincubator#10521 (comment).

Reviewed By: pedroerp

Differential Revision: D61053625
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61053625

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7474bae.

Copy link

Conbench analyzed the 1 benchmark run on commit 7474baee.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants