Skip to content

fix(runAction): guard against undefined pull request number #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2025
Merged

fix(runAction): guard against undefined pull request number #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 30 additions & 12 deletions src/github/runAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,21 @@ export async function runAction(
);
// Prefix issue/PR title with [WIP] when work starts
{
const issueNumber = agentEvent.github.issue.number;
const originalTitle = agentEvent.github.issue.title;
const strippedTitle = originalTitle.replace(/^\[(?:WIP|Done)\]\s*/, '');
const newTitle = `[WIP] ${strippedTitle}`;
core.info(`Updating issue/PR #${issueNumber} title to '${newTitle}'`);
await octokit.rest.issues.update({ ...repo, issue_number: issueNumber, title: newTitle });
const isIssue = 'issue' in agentEvent.github;
const number = isIssue
? agentEvent.github.issue.number
: agentEvent.github.pull_request.number;
const title = isIssue
? agentEvent.github.issue.title
: agentEvent.github.pull_request.title ?? '';
const stripped = title.replace(/^\[(?:WIP|Done)\]\s*/, '');
const newTitle = `[WIP] ${stripped}`;
core.info(`Updating issue/PR #${number} title to '${newTitle}'`);
await octokit.rest.issues.update({
...repo,
issue_number: number,
title: newTitle,
});
}

const progressSteps = [
Expand Down Expand Up @@ -262,12 +271,21 @@ export async function runAction(

// Prefix issue/PR title with [Done] when work completes
{
const issueNumber = agentEvent.github.issue.number;
const originalTitle = agentEvent.github.issue.title;
const strippedTitle = originalTitle.replace(/^\[(?:WIP|Done)\]\s*/, '');
const newTitle = `[Done] ${strippedTitle}`;
core.info(`Updating issue/PR #${issueNumber} title to '${newTitle}'`);
await octokit.rest.issues.update({ ...repo, issue_number: issueNumber, title: newTitle });
const isIssue = 'issue' in agentEvent.github;
const number = isIssue
? agentEvent.github.issue.number
: agentEvent.github.pull_request.number;
const title = isIssue
? agentEvent.github.issue.title
: agentEvent.github.pull_request.title ?? '';
const stripped = title.replace(/^\[(?:WIP|Done)\]\s*/, '');
const newTitle = `[Done] ${stripped}`;
core.info(`Updating issue/PR #${number} title to '${newTitle}'`);
await octokit.rest.issues.update({
...repo,
issue_number: number,
title: newTitle,
});
}
core.info('Action completed successfully.');
try {
Expand Down