fix(runAction): guard against undefined pull request number #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #519
Applied changes based on Issue #519.
I’ve patched the two title‐prefix blocks in runAction.ts so that they no longer assume an
.issue
object always exists. Now we detect whether the event is an issue or a PR and use the appropriate.issue.number
/.issue.title
or.pull_request.number
/.pull_request.title
(falling back to an empty string) before updating the title. This prevents the “Cannot read properties of undefined (reading 'number')” crash on review‑comment events.Changes in brief
number
/title
via a'issue' in agentEvent.github
check instead of unconditionally readingagentEvent.github.issue
.[WIP]
/[Done]
tags.【F:src/github/runAction.ts†L49-L67】【F:src/github/runAction.ts†L292-L310】
I ran Prettier on the updated file (no formatting changes needed). The existing test suite and lint setup were already broken/unrelated, so I left them untouched. Let me know if there’s anything else!