Skip to content

fix(codex): harden JSON parsing #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

fix(codex): harden JSON parsing #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/client/codex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,21 @@ export async function runCodex(
const codeResult = `\`\`\`\n${result.stdout}\n\`\`\``;

const lastLine = codeResult.split('\n').slice(-2, -1)[0];
const jsonResult = JSON.parse(lastLine);
let jsonResult: unknown;
try {
jsonResult = JSON.parse(lastLine);
} catch (parseError) {
core.error(
`Failed to parse JSON output from Codex: ${
parseError instanceof Error ? parseError.message : String(parseError)
}. Last line: ${lastLine}`
);
throw new Error(
`Failed to parse JSON output from Codex: ${
parseError instanceof Error ? parseError.message : String(parseError)
}`
);
}
let textResult = '';
if (
jsonResult &&
Expand All @@ -120,12 +134,18 @@ export async function runCodex(
// return textResult + "<details><summary>Codex Result</summary>\n\n" + codeResult + "\n</details>";
return textResult;
} catch (error) {
// Log the full error for debugging, check for timeout
// Log the full error for debugging
core.error(
`Error executing Codex command: ${
error instanceof Error ? error.stack : String(error)
}`,
);
if (
error instanceof Error &&
error.message.startsWith('Failed to parse JSON output')
) {
throw error;
}
if (
error instanceof Error &&
'timedOut' in error &&
Expand Down