fix(codex): harden JSON parsing #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #316
Applied changes based on Issue #316.
I’ve hardened the JSON parsing in the Codex CLI integration by:
• Wrapping the
JSON.parse(lastLine)in its own try/catch to log the exact parse error and include the offending line.• Throwing a clear “Failed to parse JSON output from Codex” error on parse failure.
• Adjusting the outer catch to detect and immediately rethrow these parse errors, so they surface clearly instead of being lumped under “Failed to execute Codex command.”
This ensures that malformed or unexpected JSON from the Codex output is handled explicitly and provides clearer diagnostics. Let me know if you’d like any additional tweaks!