-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified the tables fit on a 120 character terminal #1080
modified the tables fit on a 120 character terminal #1080
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
- Coverage 81.84% 81.78% -0.06%
==========================================
Files 24 24
Lines 19989 20002 +13
==========================================
- Hits 16359 16358 -1
- Misses 3630 3644 +14
☔ View full report in Codecov by Sentry. |
@hitenkoku Thank you!
|
Thank you for your check.
Ok, I'll try it. |
The display was broken when the table had 5 columns at 165 characters, so I modified the table to have 4 columns up to 169 characters in cb4e831 . |
@hitenkoku Thanks again. Mac terminalではテーブルが壊れる場合があるので、条件の幅の微調整をしています。少々お待ちください。 |
@YamatoSecurity 9d99f9e で以下の対応が完了しました。ご確認をお願いいたします。 |
@hitenkoku ありがとうございます!ターミナルの幅を狭くしても、テーブルが崩れないで良い感じです: 幅が十分広くても、最大数が50文字?で最後が |
はい、大丈夫です。少々お待ちください |
対応完了しました。十分に長い文字列数の設定を最大値に設定したためこれで省略されることはなくなったかと思います(200文字を最大値に修正) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku ありがとうございました!とても良い感じです。LGTM.
迅速な確認ありがとうございます!それではマージさせていただきます |
What Changed
I would appreciate it if you could review when you have time.