Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the tables fit on a 120 character terminal #1071

Closed
YamatoSecurity opened this issue Jun 1, 2023 · 0 comments · Fixed by #1080
Closed

Make sure the tables fit on a 120 character terminal #1071

YamatoSecurity opened this issue Jun 1, 2023 · 0 comments · Fixed by #1080
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@YamatoSecurity
Copy link
Collaborator

Currently, on the default command/powershell prompt terminal of 120 characters, the tables will break when there is lots of output:
Screen Shot 2023-06-01 at 9 33 28 PM
Screen Shot 2023-06-01 at 9 35 38 PM

For the Rule Authors table, it needs to be about 17 characters shorter but the limit length is now 27 and changing it to only 10 characters would cut off almost all names... so we probably need to change the table from 4 columns to 3. If we can detect the terminal character size we can increase the number of columns to 4 or more based on how wide the terminal is.

For alert rule titles, if we word wrap after 50 characters it shouldn't break the table.

@YamatoSecurity YamatoSecurity added this to the v2.6.0 milestone Jun 1, 2023
@hitenkoku hitenkoku added the enhancement New feature or request label Jun 1, 2023
hitenkoku added a commit that referenced this issue Jun 3, 2023
hitenkoku added a commit that referenced this issue Jun 3, 2023
@hitenkoku hitenkoku linked a pull request Jun 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants