Update decompositions.py and readds the Takagi decomposition #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1891 1927 +36
=========================================
+ Hits 1891 1927 +36
Continue to review full report in Codecov by Sentry.
|
nquesada
changed the title
Fixes urllib3 v2.0 not supporting versions <1.1.1 of openSSL. See readthedocs/readthedocs.org#10290.
This reverts commit db0e8d7.
|
Failing doc build is fixed by merging #364 |
nquesada
added a commit
that referenced
this pull request
May 31, 2023
* Refactor sphinx config and bump docs python version (#364) * fix [.readthedocs.yml] - increase python version Fixes urllib3 v2.0 not supporting versions <1.1.1 of openSSL. See readthedocs/readthedocs.org#10290. * fix [.readthedocs.yml] - set container image and python version * unpin doc requirements * Update decompositions.py and readds the Takagi decomposition (#363) * Update decompositions.py * New takagi * New takagi * Passes black * Simplifies blochmessiah * Simplifies blochmessiah * Found a case that breaks Takagi * Fixes all the tests * Fixes issues found by the linter * Adds extra test * Adds extra test * dummy * dummy * fix [.readthedocs.yml] - increase python version Fixes urllib3 v2.0 not supporting versions <1.1.1 of openSSL. See readthedocs/readthedocs.org#10290. * fix [.readthedocs.yml] - set container image and python version * unpin doc requirements * Revert "fix [.readthedocs.yml] - increase python version" This reverts commit db0e8d7. --------- Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain> Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> * Dummy commit * Passes black * linting * Updates module summary --------- Co-authored-by: Sebastián Duque Mesa <675763+sduquemesa@users.noreply.github.com> Co-authored-by: Nicolas Quesada <nquesada@pop-os.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the construction of
blochmessiahand addstakagiwith a very simple elegant implementation derived from http://info.phys.unm.edu/~caves/courses/qinfo-s17/lectures/polarsingularAutonne.pdf .Note that this implementation of
takagishould replace the implementation oftakagiin strawberryfields here.More generally,
bloch_messiahandwilliamsonshould not remain insfand instead just be imported from here.