Removes decomps already in thewalrus #739
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
[X ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
[X ] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.[X ] Ensure that the test suite passes, by running
make test
.[ X] Ensure that code and tests are properly formatted, by running
make format
orblack -l 100 <filename>
on any relevant files. You will need to have the Black code format installed:pip install black
.[ X] Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
[X ] The Strawberry Fields source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint
, and thenrun
pylint strawberryfields/path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
A number of decompositions already exist in
thewalrus
that are better tested and perform better. This will work only when XanaduAI/thewalrus#363 is merged.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: