Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullable annotations to UI projects #997

Merged
merged 14 commits into from
Mar 13, 2022
Merged

Add nullable annotations to UI projects #997

merged 14 commits into from
Mar 13, 2022

Conversation

sungam3r
Copy link
Collaborator

@sungam3r sungam3r commented Mar 9, 2022

Also:

  • moves JsonSerializerOptions into static field in HealthCheckReportCollector
  • adds xunit.runner.json file with settings allowing to track long running tests

@sungam3r sungam3r added the enhancement New feature or request label Mar 9, 2022
@sungam3r
Copy link
Collaborator Author

@carlosrecuero Tests from HealthChecks.UI.Tests project hang for some reason (never return). I enabled tests for healthchecks_ui_ci.yml and now trying to make it work.

@sungam3r
Copy link
Collaborator Author

Regarding my last comment - it's worth to deal with hanging tests in separate PR.

@sungam3r sungam3r merged commit 3f0462c into master Mar 13, 2022
@sungam3r sungam3r deleted the nullable branch March 13, 2022 13:59
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants