-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for using IServiceProvider when configuring Rabbitmq #915
Merged
sungam3r
merged 32 commits into
Xabaril:master
from
isdaniel:rabbitmq-heartbeat-extension-1
Feb 23, 2022
Merged
Added support for using IServiceProvider when configuring Rabbitmq #915
sungam3r
merged 32 commits into
Xabaril:master
from
isdaniel:rabbitmq-heartbeat-extension-1
Feb 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilderExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…nTests.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…uilderExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…uilderExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…uilderExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…uilderExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…ts.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…uilderExtensions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…AspNetCore.Diagnostics.HealthChecks into rabbitmq-heartbeat-extension-1
@sungam3r I had edited my PR & tried to rebase onto master, I seldom do rebase I am not sure that is correct |
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…eckBuilderExtensions.cs
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…eckBuilderExtensions.cs
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…eckBuilderExtensions.cs
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…eckBuilderExtensions.cs
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…eckBuilderExtensions.cs
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…eckBuilderExtensions.cs
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
src/HealthChecks.Rabbitmq/DependencyInjection/RabbitMQHealthCheckBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/DependencyInjection/RegistrationTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/DependencyInjection/RegistrationTests.cs
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/Functional/RabbitHealthCheckTests.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Feb 23, 2022
test/HealthChecks.RabbitMQ.Tests/Functional/RabbitHealthCheckTests.cs
Outdated
Show resolved
Hide resolved
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request is supported for configuring the connection and option using an
IServiceProvider
similar to how theSqlServerHealthCheck
supports this for a connection string & Uri.So instead of this:
We need to set string type for Rabbitmq connection from heartbeat before.
You can now do something like the code below.
Special notes for your reviewer:
This is based on the connectionStringFactory implementation in the SqlServerHealthCheck.
I had added some unit tests & functional tests for this feature, I passed by this picture below
Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list:
It extends but does not break the existing options for configuring a RabbitMQ HealthCheck