Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close IModel in RabbitMQHealthCheck #867

Merged
merged 16 commits into from
Feb 18, 2022
Merged

Close IModel in RabbitMQHealthCheck #867

merged 16 commits into from
Feb 18, 2022

Conversation

sungam3r
Copy link
Collaborator

fixes #863

@sungam3r sungam3r added the enhancement New feature or request label Nov 27, 2021
@sungam3r
Copy link
Collaborator Author

Well, for some reason I see Response status code does not indicate success: 503 (Service Unavailable) for RabbitMQ job. And even for Oracle job where I have made only cosmetic changes.

@rwkarg
Copy link
Contributor

rwkarg commented Dec 6, 2021

See #863 (comment)
This appears unnecessary and potentially more dangerous.

# Conflicts:
#	.github/workflows/healthchecks_ui_cd.yml
@sungam3r sungam3r changed the base branch from netcore-6.0 to master February 18, 2022 17:29
@sungam3r sungam3r merged commit d167815 into master Feb 18, 2022
@sungam3r sungam3r deleted the model-check branch February 18, 2022 18:12
@sungam3r sungam3r mentioned this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RabbitMQ channel is not closed correctly
2 participants